ni / nidaqmx-python

A Python API for interacting with NI-DAQmx
Other
447 stars 161 forks source link

nidaqmx: Fix installation with Python 3.13 #645

Closed bkeryan closed 1 month ago

bkeryan commented 1 month ago

What does this Pull Request accomplish?

Update the dependency versions in pyproject.toml to be compatible with Python 3.13. For per-Python version constraints, make sure the last version is ^3.13 so that it will also cover 3.14, etc.

Loosen protobuf version constraint to allow protobuf 5.x because grpcio-tools 1.67 requires protobuf 5.x.

Enable running unit tests with Python 3.13 for the PR/CI workflows. I didn't do this for system tests yet because we need to update our self-hosted runner image.

Fix a couple of system test failures:

Why should this Pull Request be merged?

Partially fixes #644

What testing has been done?

poetry run pytest -v

=============================================== short test summary info ===============================================
FAILED tests/component/system/test_device_properties.py::test___ext_cal_last_date_and_time___no_errors[library_init_kwargs] - assert 2009 > 2009
FAILED tests/component/system/test_device_properties.py::test___ext_cal_last_date_and_time___no_errors[grpc_init_kwargs] - assert 2009 > 2009
========================= 2 failed, 2286 passed, 48 skipped, 11 xfailed in 200.26s (0:03:20) ==========================

The failures are expected, I have a really old X Series board that has never been recalibrated.

github-actions[bot] commented 1 month ago

Test Results

    36 files  +  2      36 suites  +2   53m 27s :stopwatch: + 1m 27s  2 348 tests ±  0   1 994 :white_check_mark: ±  0    354 :zzz: ±0  0 :x: ±0  42 692 runs  +420  36 440 :white_check_mark: +420  6 252 :zzz: ±0  0 :x: ±0 

Results for commit ecd6806a. ± Comparison against base commit 41cb6ba3.

:recycle: This comment has been updated with latest results.