search

ni / nidaqmx-python

A Python API for interacting with NI-DAQmx
Other
447 stars 161 forks source link

tox.ini: Enable Python 3.13 #646

Closed bkeryan closed 1 month ago

bkeryan commented 1 month ago

What does this Pull Request accomplish?

Enable running system tests with Python 3.13.

Why should this Pull Request be merged?

Finish fixing #644

What testing has been done?

None

bkeryan commented 1 month ago

The py64 runner has been updated but the py32 runner has not.

github-actions[bot] commented 1 month ago

Test Results

    38 files  +    2      38 suites  +2   58m 32s :stopwatch: + 5m 16s  2 348 tests ±    0   1 994 :white_check_mark: ±    0    354 :zzz: ±  0  0 :x: ±0  46 232 runs  +3 540  39 434 :white_check_mark: +2 994  6 798 :zzz: +546  0 :x: ±0 

Results for commit e2152986. ± Comparison against base commit ee791a36.

bkeryan commented 1 month ago

I double-checked the output to make sure it's actually running 3.13.

py32: https://github.com/ni/nidaqmx-python/actions/runs/11376831246/job/31650061261?pr=646

py313-base: skipped because could not find python interpreter with spec(s): py313
py313-base: SKIP ⚠ in 2.42 seconds

This is due to the fact that creating an updated py32 image failed.

py64: https://github.com/ni/nidaqmx-python/actions/runs/11376831246/job/31650061486?pr=646

py313-grpc: commands[0]> poetry run python --version
Python 3.13.0

py64 works and py32 fails gracefully, so I guess this PR doesn't have to wait for the new py32 image. I will manually run the tests on 32-bit Python, though.

bkeryan commented 1 month ago 
PS D:\dev\nidaqmx-python> poetry run pytest -v
=================================================== test session starts ===================================================
platform win32 -- Python 3.13.0, pytest-8.3.3, pluggy-1.5.0 -- D:\dev\nidaqmx-python\.venv\Scripts\python.exe
...
================================================= short test summary info =================================================
FAILED tests/component/system/test_device_properties.py::test___ext_cal_last_date_and_time___no_errors[library_init_kwargs] - assert 2009 > 2009
FAILED tests/component/system/test_device_properties.py::test___ext_cal_last_date_and_time___no_errors[grpc_init_kwargs] - assert 2009 > 2009
=========================== 2 failed, 2286 passed, 48 skipped, 11 xfailed in 212.89s (0:03:32) ============================