Pick up new metadata for mioDAQ configurable digital voltage feature

ni / nidaqmx-python

A Python API for interacting with NI-DAQmx

Other

447 stars 161 forks source link

Pick up new metadata for mioDAQ configurable digital voltage feature #653

Closed SiuFong-NI closed 2 weeks ago

SiuFong-NI commented 3 weeks ago

[x] This contribution adheres to CONTRIBUTING.md.

What does this Pull Request accomplish?

Pickup new DAQmx metadata, updated attributes.py and enums.py.

Why should this Pull Request be merged?

To support configurable digital voltage feature for mioDAQ.

What testing has been done?

Ran poetry run pytest against 2 NI MAX configuration files specified in CONTRIBUTING.md.

SiuFong-NI commented 3 weeks ago

My first PR from github, just curious how do we complete a PR here? Do we have an auto-complete option?

zhindes commented 3 weeks ago

My first PR from github, just curious how do we complete a PR here? Do we have an auto-complete option?

There is, but you might need permission. I see this at the bottom:

What do you see?

SiuFong-NI commented 2 weeks ago

Let's filter out the Power stuff since its not fully cooked. See Brad/my comments on the metadata PR.

Updated in latest commit, verified that generated files excluded CalculatedPower related stuff.

My first PR from github, just curious how do we complete a PR here? Do we have an auto-complete option?

There is, but you might need permission. I see this at the bottom:

What do you see?

Just saw the statement mentioned "Merging can be performed automatically once the requested changes are addressed.", so I guess it does but just pending the condition.

SiuFong-NI commented 2 weeks ago

My latest commit was to pull latest nidaqmx.proto from my grpc-device PR: https://github.com/ni/grpc-device/pull/1115

SiuFong-NI commented 2 weeks ago

Pending grpc-device-scrapigen https://github.com/ni/grpc-device-scrapigen/pull/251 to be merged before merging this PR.

Looks like I do not have permission to complete the merge in this repo, @zhindes probably need your help later.

Or probably someone can grant me a write access?

charitylxy commented 2 weeks ago

@SiuFong-NI completed the PR for you

SiuFong-NI commented 2 weeks ago

Thanks @charitylxy for the help. Initially I was waiting for the https://github.com/ni/grpc-device-scrapigen/pull/251 to be merged first, I guess this change is independent so probably safe to merge first.