ni / nimble

The NI Nimble Design System
https://nimble.ni.dev
MIT License
29 stars 9 forks source link

Update Nimble usage of DesignSystem.tagFor to use component exported value #1095

Closed fredvisser closed 11 months ago

fredvisser commented 1 year ago

🧹 Tech Debt

As part of https://github.com/ni/nimble/pull/1078 : Enable TurboSnap for Chromatic tests - we exported DesignSystem.tagFor(ComponentClass) for each Nimble component.

We should use the new tag names consistently in Nimble instead of DesignSystem.tagFor where it makes sense (i.e. not for injecting the component registered to a base class but for when tags are used directly).

Looks like there are quite a few uses of DesignSystem.tagFor() in Nimble code and a couple references to it in CONTRIBUTING too: github search.

m-akinc commented 11 months ago

Appears to be done