ni / nimble

The NI Nimble Design System
https://nimble.ni.dev
MIT License
32 stars 8 forks source link

New icons for table expand – visual design request #2046

Closed fredvisser closed 4 months ago

fredvisser commented 5 months ago

🎨 Visual Design Request

  1. The icons used in the 'table-fullscreen' and 'table-not-fullscreen' buttons are on the top-right of the screen, so the arrows should point up and to the right. Our current icons would work if the buttons were on the top-left, but alas. Can we make new icons with each turned 90º?
Screenshot 2024-04-29 at 10 12 24 AM Screenshot 2024-04-29 at 10 13 05 AM
NIbokeefe commented 4 months ago

@fredvisser @jattasNI

Please the related task icon tokens plus additional icon tokens

arrow-down-left-and-arrow-up-right_16x16 Image

Tags: Collapse, Shrink, Reduce Size

arrow-up-right-and-arrow-down-left_16x16 Image

Tags: Expand, Grow, Enlarge Size

Additional adds:

debug_16x16 Image

Tags: Debug, Troubleshoot

ai-magic-circle_16x16 Image

Tags: Artificial Intelligence, Magic, Advanced Automate

jattasNI commented 4 months ago

@NIbokeefe I've got a PR up to add these icons (and the clean icon). Just want to double check that the intent with the multi-colored AI icon is that it shouldn't change at all in dark/color theme and that clients wouldn't ever set its "severity" to error/warning.

You can see what this looks like here: https://60e89457a987cf003efc0a5b-gmwijpogcx.chromatic.com/?path=/story/components-icons--icons&globals=backgrounds.grid:!false;backgrounds.value:!hex(252526)

NIbokeefe commented 3 months ago

@jattasNI All good questions and points.

Looks like that version is only going to be good for light UI. Color UI could can only be White, so that's an interesting aspect where it would not be in full color.

I don't imagine allowing status to this one.

Let me circle back around for these questiions, I'm not entirely sure the whole scope of where and how the AI team will use this asset. I'm glad to have the Light UI version for now so they have something, and hopefully should have more info later.