ni / nimble

The NI Nimble Design System
https://nimble.ni.dev
MIT License
29 stars 8 forks source link

Move anchored region import from menu to menu item #2051

Closed m-akinc closed 2 months ago

m-akinc commented 2 months ago

Pull Request

๐Ÿคจ Rationale

Saw an issue in the menu matrix story where sub-menus looked wrong. Turns out it was because AnchoredRegion had not been registered, and FAST's menu item template was using tagFor(AnchoredRegion).

๐Ÿ‘ฉโ€๐Ÿ’ป Implementation

We already had an import of anchored-region in the menu code, but it really belongs in menu item. Moved it.

๐Ÿงช Testing

Trusting Chromatic.

โœ… Checklist