In one of the test files we forked from Angular (router_integration_spec.ts) there are two components, AbsoluteSimpleLinkCmp and RelativeLinkCmp that have identical selector and template values, which can lead to component ID collisions. We worked around this by adding an irrelevant :not(head) to RelativeLinkCmp's selector, however it turns out that there is another definition of RelativeLinkCmp earlier in the file (with unmodified selector) that can still lead to an ID collision. I switched the selector "uniquification" to AbsoluteSimpleLinkCmp, so now it should not collide with either of the RelativeLinkCmp definitions.
🧪 Testing
Ran tests locally.
✅ Checklist
[x] I have updated the project documentation to reflect my changes or determined no changes are needed.
Pull Request
🤨 Rationale
A build hit a test failure unrelated to the changes in that PR: https://github.com/ni/nimble/actions/runs/9009318573/job/24753280540?pr=2083
👩💻 Implementation
In one of the test files we forked from Angular (
router_integration_spec.ts) there are two components,AbsoluteSimpleLinkCmpandRelativeLinkCmpthat have identicalselectorandtemplatevalues, which can lead to component ID collisions. We worked around this by adding an irrelevant:not(head)toRelativeLinkCmp's selector, however it turns out that there is another definition ofRelativeLinkCmpearlier in the file (with unmodified selector) that can still lead to an ID collision. I switched the selector "uniquification" toAbsoluteSimpleLinkCmp, so now it should not collide with either of theRelativeLinkCmpdefinitions.🧪 Testing
Ran tests locally.
✅ Checklist