search

ni / nimble

The NI Nimble Design System
https://nimble.ni.dev
MIT License
29 stars 9 forks source link

Error icon is incorrectly spaced in nimble-text-field #2090

Open mollykreis opened 1 month ago

mollykreis commented 1 month ago

🐛 Bug Report

In the nimble-text-field, the error "!" icon should be 8px from the edge of the component. However, it is currently 8px from the border, which makes it 9px from the edge of the component.

We should evaluate whether this is the case with other components as well.

💻 Repro or Code Sample

🤔 Expected Behavior

The error icon in components should be 8px from the edge of the component, not 8px from the border of the component.

😯 Current Behavior

The error icon is 8px from the border of the component.

💁 Possible Solution

🔦 Context

🌍 Your Environment

mollykreis commented 1 month ago

When this is fixed, we should remove the workaround added in this azdo PR to make the checkbox error icon align with the textfield error icon. Specifically, an extra 1px of padding was added to the right of the checkbox's error icon.