ni / nimble

The NI Nimble Design System
https://nimble.ni.dev
MIT License
32 stars 8 forks source link

Require an icon to be specified on icon mappings #2103

Closed mollykreis closed 4 months ago

mollykreis commented 4 months ago

Pull Request

๐Ÿคจ Rationale

In #1874, we introduced the ability to have icon mappings with an undefined icon to support use cases where the cell should be empty with non-empty group rows and where the cell should have only text. These use cases are now covered by usages of nimble-mapping-empty and nimble-mapping-text, both of which are supported by the mapping column. Therefore, we no longer need to support icon mappings without an icon.

๐Ÿ‘ฉโ€๐Ÿ’ป Implementation

Mostly reverting #1874, with a few minor updates to account for updates made in the source since the change was put it.

๐Ÿงช Testing

โœ… Checklist

mollykreis commented 4 months ago

@m-akinc, will you buddy this PR for me?