search

ni / nimble

The NI Nimble Design System
https://nimble.ni.dev
MIT License
32 stars 8 forks source link

Support tabindex overriding for Button, MenuButton, ToggleButton, Checkbox, and Anchor #2110

Closed m-akinc closed 4 months ago

m-akinc commented 4 months ago

Pull Request

🤨 Rationale

Fixes #2094

👩‍💻 Implementation

For each of Button, MenuButton, ToggleButton, 'Checkbox', and Anchor, added tabindex attribute, updated the template to forward the tabindex value, and wrote automated tests. Additionally for Button and Checkbox, forked template from FAST and copied over the FAST tests.

🧪 Testing

Ran tests. Manually tested in Storybook in Chrome and Firefox.

✅ Checklist

m-akinc commented 4 months ago

@msmithNI Will you buddy this for me?