ni / nimble

The NI Nimble Design System
https://nimble.ni.dev
MIT License
29 stars 9 forks source link

Long words can cause cut-off text in banner #2153

Closed epetersoni closed 4 weeks ago

epetersoni commented 1 month ago

πŸ› Bug Report

Especially if horizontal space is limited, multi-line banner messages with long words can cause some text and icons to get cut off.

πŸ’» Repro or Code Sample

Example: image

Give any Nimble Banner a message with multiple words, one of which is long enough to not fit within the width the banner has to work with.

Note that our banner also has two buttons, which are not shown because of the long word: image

πŸ€” Expected Behavior

The banner picks one or more places in the long word to split onto the next line. Other banner content to the right of the text, such as buttons, is visible.

😯 Current Behavior

See above screenshot.

πŸ’ Possible Solution

Have the UI split onto a new line at appropriate places in long words.

πŸ”¦ Context

These error messages are coming from TestStand, so our simple sequencer doesn't have a good way to specify or update the text being displayed. It seems like the fix needs to come from the UI control.

🌍 Your Environment

epetersoni commented 2 weeks ago

Just confirming that I updated our Nimble version, and this fix is working as expected. The top banner from the bug now looks like this: image