Closed rajsite closed 4 weeks ago
It helps a lot and I think is uncontroversial so gonna override merge, but let me know if there are concerns @atmgrifter00 @jattasNI to address in follow-up
I've spent a lot of time scrolling through test logs recently and haven't been loving this experience, so this seems like a good step (assuming it still gives a good summary when a test fails).
I've thought about pulling in a test reporter like this one but they require a bit of GitHub Action tweaking so I haven't gotten around to it; maybe next innovation day.
I've spent a lot of time scrolling through test logs recently and haven't been loving this experience, so this seems like a good step (assuming it still gives a good summary when a test fails).
I've thought about pulling in a test reporter like this one but they require a bit of GitHub Action tweaking so I haven't gotten around to it; maybe next innovation day.
I don't really like coupling to GitHub Actions from random individuals and GitHub doesn't have a native test reporting / tracking feature. That just prints a markdown summary table and wouldn't get test failure / execution time history which I really would like.
I think it would be neat to push our test results to SLE to be able to trace history or individual test steps etc. Another innovation day idea :D
Pull Request
๐คจ Rationale
With a single validate command running all validation the verbosity of the angular karma logs makes it difficult to scan logs and identify test failures vs lint failures etc.
๐ฉโ๐ป Implementation
Switched angular to use
karma-spec-reporter
with low verbosity settings like nimble-components has been.๐งช Testing
Ran locally and rely on CI.
โ Checklist