ni / nimble

The NI Nimble Design System
https://nimble.ni.dev
MIT License
29 stars 9 forks source link

Angular reduce test verbosity #2159

Closed rajsite closed 4 weeks ago

rajsite commented 4 weeks ago

Pull Request

๐Ÿคจ Rationale

With a single validate command running all validation the verbosity of the angular karma logs makes it difficult to scan logs and identify test failures vs lint failures etc.

๐Ÿ‘ฉโ€๐Ÿ’ป Implementation

Switched angular to use karma-spec-reporter with low verbosity settings like nimble-components has been.

๐Ÿงช Testing

Ran locally and rely on CI.

โœ… Checklist

rajsite commented 4 weeks ago

It helps a lot and I think is uncontroversial so gonna override merge, but let me know if there are concerns @atmgrifter00 @jattasNI to address in follow-up

jattasNI commented 4 weeks ago

I've spent a lot of time scrolling through test logs recently and haven't been loving this experience, so this seems like a good step (assuming it still gives a good summary when a test fails).

I've thought about pulling in a test reporter like this one but they require a bit of GitHub Action tweaking so I haven't gotten around to it; maybe next innovation day.

rajsite commented 4 weeks ago

I've spent a lot of time scrolling through test logs recently and haven't been loving this experience, so this seems like a good step (assuming it still gives a good summary when a test fails).

I've thought about pulling in a test reporter like this one but they require a bit of GitHub Action tweaking so I haven't gotten around to it; maybe next innovation day.

I don't really like coupling to GitHub Actions from random individuals and GitHub doesn't have a native test reporting / tracking feature. That just prints a markdown summary table and wouldn't get test failure / execution time history which I really would like.

I think it would be neat to push our test results to SLE to be able to trace history or individual test steps etc. Another innovation day idea :D