the AI icon uses "sparkle-swirls" since we generally want to avoid metaphors but I didn't see a FontAwesome equivalent
the debug icon uses "debug" since descriptive names seemed silly ("shield-with-legs"?) and the metaphor seems unique
(open to feedback on all the above)
Synonyms: used the ones Brandon suggested
I stripped color from all icons except the AI icon. This doesn't match our CONTRIBUTING guidance and caused a test to fail. I'm proposing an update to the guidance and removing those asserts from the test.
I considered establishing a convention where <defs> were allowed in svgs only if you explicitly tag them with a custom attribute that proves you left them in intentionally. But I lean towards just relying on code review to enforce best practices.
Note: #327 would be another opportunity for us to improve this if we want themeable multicolored icons.
Minor update to use the new npm run storybook command in a CONTRIBUTING doc
๐งช Testing
Local storybook inspection
โ Checklist
[x] I have updated the project documentation to reflect my changes or determined no changes are needed.
I'll be OOO most of tomorrow. Someone is welcome to push this through before I'm back if the builds pass (I know one client was hoping for the icons to be available this week). @fredvisser @rajsite
Pull Request
๐คจ Rationale
New icons are available. One of them is multicolored and we'd like to retain those colors.
Resolves #2138 Resolves #2046
๐ฉโ๐ป Implementation
Generally followed CONTRIBUTING instructions for adding icons.
<defs>
were allowed in svgs only if you explicitly tag them with a custom attribute that proves you left them in intentionally. But I lean towards just relying on code review to enforce best practices.npm run storybook
command in a CONTRIBUTING doc๐งช Testing
Local storybook inspection
โ Checklist