Open m-akinc opened 3 weeks ago
If I'm reading https://github.com/microsoft/playwright/issues/31004 right should we should expect OffscreenCanvas support in the next playwright release?
Hopefully, but it's hard to tell for sure. You think we should leave the tests enabled until next quarter's manual maintenance pass?
Makes sense they were disabled in #2171 so those who do try and test in WebKit don't hit unexpected issues. Added a note to teh recurring playwright task to double check this issue and see if the tests can be re-enabled.
Might be relevant: It should be also fixed in our Canary releases.
🧹 Tech Debt
The wafer map uses the
OffscreenCanvas
feature that was added to Safari in version 17, but is explicitly disabled in the WebKit build (see collapsed comment) for Windows/Linux platforms. The WebKit commit for theOffscreenCanvas
feature confirms this (see LayoutTests/platform/win/TestExpectations).Therefore, we had to disable any wafer map tests that exercise
OffscreenCanvas
code in WebKit:nimble-components/build/generate-workers/source/tests/matrix-renderer.spec.ts
(all tests)nimble-components/src/wafer-map/tests/create-matrix-renderer.spec.ts
(all tests)nimble-components/src/wafer-map/tests/hover-handler.spec.ts
(all tests)nimble-components/src/wafer-map/tests/wafer-map.spec.ts
:describe
block