ni / nimble

The NI Nimble Design System
https://nimble.ni.dev
MIT License
29 stars 9 forks source link

Move column sorting properties to a column mixin #2190

Closed mollykreis closed 2 weeks ago

mollykreis commented 2 weeks ago

Pull Request

🤨 Rationale

Currently, there is no way for a table column to not support sorting because the sorting attributes (sorting-disabled, sort-index, and sort-direction) are defined on the base TableColumn class. The menu button column, however, should not allow sorting. Therefore, the three sorting attributes are being moved off of the base TableColumn class and into a mixin, that every existing column now uses.

👩‍💻 Implementation

nimble-components

nimble-angular

nimble-blazor

🧪 Testing

✅ Checklist

mollykreis commented 2 weeks ago

@m-akinc, will you buddy this PR for me?

rajsite commented 2 weeks ago

Gonna override merge since it's pretty mechanical and following existing patterns. If concerns @jattasNI @atmgrifter00 @msmithNI I'm sure we can address in a follow-up