ni / nimble

The NI Nimble Design System
https://nimble.ni.dev
MIT License
29 stars 9 forks source link

Define graph trace color tokens #2194

Closed m-akinc closed 1 week ago

m-akinc commented 2 weeks ago

Pull Request

๐Ÿคจ Rationale

Addresses #787

๐Ÿ‘ฉโ€๐Ÿ’ป Implementation

Added 8 color tokens for graph traces, e.g. graphTrace1Color.

Per the design, we cannot provide graph trace tokens that work generally for monochromatic applications. If the use case only requires a single trace, then it seems correct for that trace (graphTrace1Color) to be white for the color theme. If there are more traces, then based on what Rick wrote in his design, the client presumably has to override the token values based on the background color. So defaulting all the traces to white seems reasonable.

๐Ÿงช Testing

Token story

โœ… Checklist