ni / nimble

The NI Nimble Design System
https://nimble.ni.dev
MIT License
29 stars 9 forks source link

Remove node polyfills no longer needed for rich text components #2195

Closed jattasNI closed 2 weeks ago

jattasNI commented 2 weeks ago

Pull Request

๐Ÿคจ Rationale

Fixes #1700. These two polyfills were added in #1335 because markdown-it implicitly depended on some functionality that existed in Node but not browser environments. We've since upgraded markdown-it to a version that expresses those dependencies on normal npm packages, so the polyfills are no longer needed. https://github.com/markdown-it/markdown-it/issues/967

๐Ÿ‘ฉโ€๐Ÿ’ป Implementation

Remove rollup plugins and npm dependencies on those plugins that were added in #1335.

๐Ÿงช Testing

Mostly depending on PR build but also spot checking rich text functionality in storybook.

โœ… Checklist