ni / nimble

The NI Nimble Design System

https://nimble.ni.dev

MIT License

29 stars 9 forks source link

Menu button page object #2197

Closed mollykreis closed 1 week ago

mollykreis commented 2 weeks ago

Pull Request

🤨 Rationale

Create menu-button page object that is exported from nimble-components and from nimble-angular.

👩‍💻 Implementation

Create page object for the menu-button
Create new menu-button/testing entry point from nimble-angular and export the page object from there
Update menu button unit tests in nimble-components to use the page object where necessary
Add waitForEventAsync utility function so that callers can wait for an event to be fired without having to have a dependency on jasmine

🧪 Testing

Unit tests still pass

✅ Checklist

[ ] I have updated the project documentation to reflect my changes or determined no changes are needed.

mollykreis commented 2 weeks ago

@m-akinc, will you buddy this PR for me?