ni / nimble

The NI Nimble Design System
https://nimble.ni.dev
MIT License
29 stars 9 forks source link

List option in group needs to register with Select #2198

Closed atmgrifter00 closed 2 weeks ago

atmgrifter00 commented 2 weeks ago

Pull Request

๐Ÿคจ Rationale

Had a realization that list options that were in a group would not go through the registerOption routine (a fix for SLE Angular apps). While I'm not sure if there is any current use-case that would hit the problem, I went ahead and made the fix and the tests that demonstrate the problem.

๐Ÿ‘ฉโ€๐Ÿ’ป Implementation

Just made the private getListOptionOwner routine on ListOption a bit more robust.

๐Ÿงช Testing

Wrote component and Angular tests modeled after existing tests but with a group as the option owner.

โœ… Checklist