ni / nimble

The NI Nimble Design System
https://nimble.ni.dev
MIT License
29 stars 9 forks source link

Update select page object #2201

Closed atmgrifter00 closed 1 week ago

atmgrifter00 commented 1 week ago

Pull Request

๐Ÿคจ Rationale

Recognized that as part of attempting to migrate an SLE component to the Select to use the grouping feature that there was a useful pageObject API for retrieving the options for a group by providing the group's label. This PR adds that functionality to the SelectPageObject.

๐Ÿ‘ฉโ€๐Ÿ’ป Implementation

Simple implementation mirroring a similar existing one.

๐Ÿงช Testing

Added test for the new pageObject method.

โœ… Checklist

atmgrifter00 commented 1 week ago

Dang it! I thought I had pushed the changes to the change file, but didn't notice the failure before I squashed the changes.

NOTICE: This was technically a breaking change, as the SelectPageObject method getGroupOptionLabels was renamed to getGroupOptionLabelsByIndex.