Primarily this is just exposing the needed attribute for controlling the visibility of the loading indicator for the Select in Angular, accompanied with an update to the example application showing how to manage dynamic options.
However, in the making of the example it became clear that a change to the Select web component was needed to make the client experience cleaner. Now, when the filter-input event is issued as part of the action of changing the value, the change event will occur first, followed by the filter-input event. This required not tying the emitting of the filter-input event to the updating of the open attribute, as we will still update the open state prior to issuing the change event.
🧪 Testing
Wrote new tests validating the new expected event ordering. Added typical Angular tests for new attribute.
✅ Checklist
[ ] I have updated the project documentation to reflect my changes or determined no changes are needed.
Pull Request
🤨 Rationale
1866
👩💻 Implementation
Primarily this is just exposing the needed attribute for controlling the visibility of the loading indicator for the
Selectin Angular, accompanied with an update to the example application showing how to manage dynamic options.However, in the making of the example it became clear that a change to the
Selectweb component was needed to make the client experience cleaner. Now, when thefilter-inputevent is issued as part of the action of changing the value, thechangeevent will occur first, followed by thefilter-inputevent. This required not tying the emitting of thefilter-inputevent to the updating of theopenattribute, as we will still update theopenstate prior to issuing thechangeevent.🧪 Testing
Wrote new tests validating the new expected event ordering. Added typical Angular tests for new attribute.
✅ Checklist