ni / nimble

The NI Nimble Design System
https://nimble.ni.dev
MIT License
29 stars 9 forks source link

Update `SelectPageObject` `clickOption` to only deal with visible options. #2221

Closed atmgrifter00 closed 4 days ago

atmgrifter00 commented 5 days ago

Pull Request

๐Ÿคจ Rationale

While doing the integration work to begin leveraging a select with grouping in SLE, I recognized that an existing page object had an API for selecting options by index, where the index was related to only the visible options in the dropdown. I feel this is more intuitive for a pageObject API than what we currently had in our own, so I'm updating our pageObject implementation to follow this.

๐Ÿ‘ฉโ€๐Ÿ’ป Implementation

Simply finding the visible options with which to relate the provided index parameter to clickOption against.

๐Ÿงช Testing

Updated tests that had to adjust the index they were using to align with only the visible options.

โœ… Checklist