ni / nimble

The NI Nimble Design System
https://nimble.ni.dev
MIT License
29 stars 9 forks source link

Avoid further instances of intermittent test component id collision #2229

Closed m-akinc closed 5 days ago

m-akinc commented 5 days ago

Pull Request

๐Ÿคจ Rationale

I thought I had resolved this in #2087, but I just ran into another case of this Angular ID collision issue in this build. This time rather than being a collision for components AbsoluteSimpleLinkCmp and RelativeLinkCmp, it's a collision between two different definitions of RelativeLinkCmp:

Failed: NG0912: Component ID generation collision detected. Components 'RelativeLinkCmp' and 'RelativeLinkCmp' with selector 'link-cmp' generated the same component ID. To fix this, you can change the selector of one of those components or add an extra host attribute to force a different ID. Find more at https://angular.io/errors/NG0912

๐Ÿ‘ฉโ€๐Ÿ’ป Implementation

Uniquified each link-cmp selector by appending :not([nimble-unused-X]).

๐Ÿงช Testing

None

โœ… Checklist