search

ni / nimble

The NI Nimble Design System
https://nimble.ni.dev
MIT License
32 stars 8 forks source link

Update @types/markdown-it to aligned and pinned version #2326

Open rajsite opened 2 months ago

rajsite commented 2 months ago

🧹 Tech Debt

The @types/markdown-it updates were disabled due to an issue in prosemirror-markdown, see https://github.com/ProseMirror/prosemirror-markdown/issues/124

When addressed we can re-enable the updates and switch from @types/markdown-it v13 to v14 (which we actually end up relying on v14 of the actual markdown-it library transitively due to prosemirror-markdown).

Additional discussion here: https://github.com/ni/nimble/pull/2318#discussion_r1700853278

rajsite commented 1 month ago

https://github.com/ProseMirror/prosemirror-markdown/issues/124 was merged but we are still blocked on release. After release the pinned version of @types/markdown-it should be updated to align with the version of markdown-it used by prosemirror-markdown.

Unfortunately we should not enable renovate as we need to manually align the @types/markdown-it version to what is used by our version of prosemirror-markdown so it should be a manual task added to https://github.com/ni/nimble/issues/1747.