ni / nimble

The NI Nimble Design System
https://nimble.ni.dev
MIT License
32 stars 8 forks source link

Error text overflow #2432

Open mollykreis opened 1 month ago

mollykreis commented 1 month ago

Pull Request

๐Ÿคจ Rationale

Fixes #2431

๐Ÿ‘ฉโ€๐Ÿ’ป Implementation

The shared error pattern has been updated to use the overflow directive to track when the error text has overflow and to only show the title when overflow is present. As part of this, each component that implements ErrorPattern was updated to include an observable property named errorHasOverflow to correctly implement the ErrorPattern interface.

๐Ÿงช Testing

Manually tested in storybook that all updated components:

โœ… Checklist

mollykreis commented 1 month ago

@m-akinc, will you buddy this PR for me?