ni / nimble

The NI Nimble Design System

https://nimble.ni.dev

MIT License

32 stars 8 forks source link

Add and update latest icons #2468

Closed jattasNI closed 1 week ago

jattasNI commented 1 week ago

Pull Request

🤨 Rationale

Fixes #2466

👩‍💻 Implementation

Followed CONTRIBUTING. Brandon's proposed names matched FontAwesome with the following exceptions:

paper-airplane -> paper-plane
star-8-point -> no font awesome equivalent, went with Brandon's suggestion
rectangle-lines -> no font awesome equivalent, went with Brandon's suggestion (name aligns with existing rectangle-check-lines)

🧪 Testing

Verified changing severity affects color of new icons Accepted Chromatic diffs. There are a lot because the pencil icon is used in many matrix tests

✅ Checklist

[x] I have updated the project documentation to reflect my changes or determined no changes are needed.

jattasNI commented 1 week ago

Bypassing you @rajsite since it's just new icons