Add set_runtime_environment functionality to nidigital

ni / nimi-python

Python bindings for NI Modular Instrument drivers.

Other

111 stars 84 forks source link

Add set_runtime_environment functionality to nidigital #1972

Closed ni-jfitzger closed 1 year ago

ni-jfitzger commented 1 year ago

[X] This contribution adheres to CONTRIBUTING.md.
[X] I've updated CHANGELOG.md if applicable.
~[] I've added tests applicable for this pull request~

This feature is tested through nifake unit tests.

What does this Pull Request accomplish?

nidigital metadata is updated from the latest internal export.
set_runtime_environment call is added to nidigital/_library_interpreter.py

List issues fixed by this Pull Request below, if any.

None

What testing has been done?

None

ni-jfitzger commented 1 year ago

@marcoskirsch the addition of this new method broke our unit tests, which want us to set its side effect. I'll have to fix it, before we can merge this.

ni-jfitzger commented 1 year ago

The pending Read the Docs builds are builds that were cancelled because there were no changes. They should be showing as skipped or successful. Maybe the issue related to this isn't actually fixed (I don't want to reference it directly in each of our changes because each mention shows up in the issue) or maybe there's something not quite right with our configuration.

Either way, this is ready for merging.