ni / nimi-python

Python bindings for NI Modular Instrument drivers.
Other
112 stars 84 forks source link

Fix codecov system-test coverage upload instability, absence of reporting for master branch #2014

Closed ni-jfitzger closed 11 months ago

ni-jfitzger commented 12 months ago

What does this Pull Request accomplish?

The coverage status badge is misreporting our coverage for 3 reasons:

  1. tokenless uploading of system-test coverage via the codecov action is unreliable
  2. system tests aren't running against master, so no system-test coverage is reported for commits to master
  3. The coverage .rc files need to be updated

This change passes a codecov token to the codecov action to fix the first problem. It adds a trigger on commits to master to github_actions_aws_windows_python64.yml to address the second problem. Problem 3 will need to be addressed separately. #2015 has been filed for that.

(Note that travis-ci already runs against commits to master, so our unit-test coverage shows up in the coverage badge).

List issues fixed by this Pull Request below, if any.

What testing has been done?

ni-jfitzger commented 12 months ago

This should not be merged until after the 1.4.6 post-release changes are merged.

ni-jfitzger commented 11 months ago

We're getting system-test runs for the master branch, now. https://github.com/ni/nimi-python/actions/runs/6267475700