Open bkeryan opened 11 months ago
BTW, providing public type aliases for Channel
, Instrument
, Pin
, Site
, etc. would be a relatively easy solution.
Channel = _SessionBase
Instrument = _SessionBase
...
Note that _SessionBase
is in nidcpower.session
and not aliased into nidcpower
, so the example code above is incorrect.
Description of issue
Repeated capability accessors like
Session.channels
andSession.instruments
return a_SessionBase
object. Clients that pass channel objects around may need to refer to this type in PEP 484 type hints.Example: https://github.com/ni/measurementlink-python/blob/9bffe48c1c2da4777eeca0ca159b74bde724ead6/examples/output_voltage_measurement/measurement.py#L177
The convention recommended in PEP8 and used by most Python code is that names with a single leading underscore are for internal use.
In general, public APIs ought to use public types.
System report
Not applicable.
Steps to reproduce issue