ni / nimi-python

Python bindings for NI Modular Instrument drivers.
Other
112 stars 84 forks source link

Use instrument_model property in nidmm system test test_vi_string_attribute #2021

Closed ni-jfitzger closed 11 months ago

ni-jfitzger commented 11 months ago

What does this Pull Request accomplish?

In a recent version of the NI-DMM, the reported serial of a simulated DMM was intentionally changed. This causes the nidmm system test test_vi_string_attribute to fail in our internal test suite and will cause failures in PR Checks when we update the version we test against.

This change updates the test to rely on instrument_model, instead of serial_number. They are both read-only properties and we do not expect the reported value for instrument_model to change in the future.

List issues fixed by this Pull Request below, if any.

What testing has been done?