Do not overwrite example testing results - Githubissues

ni / nimi-python

Python bindings for NI Modular Instrument drivers.

Other

112 stars 84 forks source link

Do not overwrite example testing results #2048

Closed ni-jfitzger closed 4 months ago

ni-jfitzger commented 4 months ago

[X] This contribution adheres to CONTRIBUTING.md.
~[ ] I've updated CHANGELOG.md if applicable.~
~[ ] I've added tests applicable for this pull request~

What does this Pull Request accomplish?

Stop creating the unused kibana jsons
Assign a different junitxml name to example test results, so they are not overwrriten by system test results
- junitxmls are only used by our internal test suites

List issues fixed by this Pull Request below, if any.

Fix #2041

What testing has been done?

Ran the system tests on a local machine for niswitch.
- Confirmed that results were being overwritten
- Confirmed that the changes produce 2 seprate test result files, so nothing is overwritten

ni-jfitzger commented 4 months ago

I wasn't originally going to do this for this release, but I wrapped up my committed work this weekend and had some time. Testing changes have to make it into a release to take effect in our internal suites.