Closed ni-juoca closed 4 months ago
Looks like you have conflicts. Try pulling down the latest changes, accepting the upstream version and running
tox -e clean
tox -e codegen
You should remove TODOs from the description, once you've addressed them.
This looks good, but we want to wait on an official export.
All tests passed on the previous change. No need to run them again for a changelog update.
[x] This contribution adheres to CONTRIBUTING.md.
[x] I've updated CHANGELOG.md if applicable.
[x] I've added tests applicable for this pull request
What does this Pull Request accomplish?
This change adds back the pulse width properties that were requested by the customer in #1873. Specifically, these properties were added:
Additionally, a shared
EventPulseWidthUnits
enum was added for setting the_event_pulse_width_units
properties.List issues fixed by this Pull Request below, if any.
What testing has been done?