ni / nimi-python

Python bindings for NI Modular Instrument drivers.
Other
112 stars 84 forks source link

[NI-FGEN] Add back pulse width properties #2051

Closed ni-juoca closed 4 months ago

ni-juoca commented 4 months ago

What does this Pull Request accomplish?

This change adds back the pulse width properties that were requested by the customer in #1873. Specifically, these properties were added:

* `started_event_pulse_width`
* `done_event_pulse_width` 
* `marker_event_pulse_width`
* `started_event_pulse_width_units`
* `done_event_pulse_width_units` 
* `marker_event_pulse_width_units`

Additionally, a shared EventPulseWidthUnits enum was added for setting the _event_pulse_width_units properties.

List issues fixed by this Pull Request below, if any.

What testing has been done?

ni-jfitzger commented 4 months ago

Looks like you have conflicts. Try pulling down the latest changes, accepting the upstream version and running

tox -e clean
tox -e codegen
ni-jfitzger commented 4 months ago

You should remove TODOs from the description, once you've addressed them.

ni-jfitzger commented 4 months ago

This looks good, but we want to wait on an official export.

ni-jfitzger commented 4 months ago

All tests passed on the previous change. No need to run them again for a changelog update.