ni / nimi-python

Python bindings for NI Modular Instrument drivers.
Other
112 stars 84 forks source link

[NI-DCPower] Address timeout issues with nidcpower_advanced_sequence.py #2052

Closed ni-juoca closed 4 months ago

ni-juoca commented 4 months ago

What does this Pull Request accomplish?

This change addresses the timeout issues that prevent nidcpower_advanced_sequence.py from running out of the box. The fix for this was initially detailed in #1664.

More specifically, the timeout is calculated using the source delay, aperture time, and total number of points.

List issues fixed by this Pull Request below, if any.

What testing has been done?

I verified that the test is working with real hardware.

ni-jfitzger commented 4 months ago

You've got flake8 failures in travis-ci in the example. Run tox -e flake8 and fix any issues it raises.

bkeryan commented 4 months ago

FYI @ni-juoca for the PR checkboxes, use [x] (no spaces) or click the checkbox after editing the markdown