ni / nimi-python

Python bindings for NI Modular Instrument drivers.
Other
112 stars 84 forks source link

Update metadata before 1.4.8 release #2055

Closed ni-jfitzger closed 4 months ago

ni-jfitzger commented 4 months ago

What does this Pull Request accomplish?

Update metadata to latest 24.3 export for most APIs. Not Updated:

Resulting Changes:

No new functions, properties, enums, classes, structs were added to any of the APIs

List issues fixed by this Pull Request below, if any.

None

What testing has been done?

PR Checks

marcoskirsch commented 4 months ago

Don't we usually add something like "API parity with NI-Digital Pattern Driver 2x.0.0." to the CHANGELOG in these PRs?

ni-jfitzger commented 4 months ago

Don't we usually add something like "API parity with NI-Digital Pattern Driver 2x.0.0." to the CHANGELOG in these PRs?

There's only evidence of us doing that when we add new functions, properties, enums, etc for API parity. This PR includes no user-visible API changes. I'm not sure what's going on with that NI-DMM grpc change, but we test both of those functions and the tests passed.

ni-jfitzger commented 4 months ago

Please confirm if this should include CHANGELOG changes. Should only be mentioned where the API changes are actually visible.

There is nothing that warrants touching the changelog. I carefully reviewed the metadata changes, multiple times, and I reviewed the output as well. All changes that I found are noted in the description.