Do not trigger system testing on PRs that don't need it - Githubissues

ni / nimi-python

Python bindings for NI Modular Instrument drivers.

Other

112 stars 84 forks source link

Do not trigger system testing on PRs that don't need it #2059

Open ni-jfitzger opened 4 months ago

ni-jfitzger commented 4 months ago

[X] This contribution adheres to CONTRIBUTING.md.
[ ] ~I've updated CHANGELOG.md if applicable.~
[ ] ~I've added tests applicable for this pull request~

What does this Pull Request accomplish?

Right now we pretty much always run system tests on our PRs, even if we're just changing the README.md.

This changes our triggering so we only run system tests in the following cases:

A workflow or the action it uses is changed
We change a generated module or its source
We change the tools folder (where we keep the coverage rc files)

I'm not changing the trigger for merges at this time.

A special setting would be needed to not mess up the reported coverage in cases where we don't run the tests
- I'm sure I could look it up, but there could be some churn
I feel more secure knowing we pretty much always run tests on the latest commit, in case I overlooked something important in our triggering requirements

List issues fixed by this Pull Request below, if any.

None

What testing has been done?

None