Create new "dataframe" subpackage

ni / nisystemlink-clients-python

Python API for interacting with a SystemLink Server, created and supported by NI.

https://ni.com/systemlink

MIT License

10 stars 17 forks source link

Create new "dataframe" subpackage #18

Closed mure closed 2 years ago

mure commented 2 years ago

[x] This contribution adheres to CONTRIBUTING.md.

What does this Pull Request accomplish?

Creates a subpackage "dataframe" that provides a new client for the DataFrame service.

Why should this Pull Request be merged?

We need a place to organize the dataframe modules.

What testing has been done?

n/a

mure commented 2 years ago

I created the class DataFrameClient which strays from the convention of the tag client that has a TagManager class instead. Does anyone have strong opinions that we should keep the "manager" convention? It would be something like DataTableManager instead.

cameronwaterman commented 2 years ago

I created the class DataFrameClient which strays from the convention of the tag client that has a TagManager class instead. Does anyone have strong opinions that we should keep the "manager" convention? It would be something like DataTableManager instead.

I agree with moving away from using "manager" in the client name. It really has no significance to the client itself.

mure commented 2 years ago

Are we still planning to rename the package to nisystemlink?

Yes, that'll be in another PR.