feat: Implement create/get/delete/list table metadata methods - Githubissues

ni / nisystemlink-clients-python

Python API for interacting with a SystemLink Server, created and supported by NI.

https://ni.com/systemlink

MIT License

10 stars 14 forks source link

feat: Implement create/get/delete/list table metadata methods #28

Closed mure closed 1 year ago

mure commented 1 year ago

[x] This contribution adheres to CONTRIBUTING.md.

What does this Pull Request accomplish?

Implements a set of table metadata routes:
- create
- get
- delete
- list
Adds a custom serializer for our Pydantic models. This is so we can set certain options like by_alias.
Switches attribute comments to use docstrings, because some of them wouldn't fit on a single line.

Why should this Pull Request be merged?

We need this functionality. (This part of the PR template is awkward. I'm never sure what to put other than "because we need it")

What testing has been done?

Added our first functional test 🎉 Feel free to suggest other test cases. I think we'll want at least one that tests an expected error.

mure commented 1 year ago

@spanglerco @cameronwaterman I was working off this branch and since the PR is still up, I went ahead and added the list_tables method as well. I'll reset the reviews so y'all can take a look.

New changes: https://github.com/ni/nisystemlink-clients-python/pull/28/commits/20f3bbfe980a5793277b0fc11d41e886d4b69c10