search

ni / nisystemlink-clients-python

Python API for interacting with a SystemLink Server, created and supported by NI.
https://ni.com/systemlink
MIT License
10 stars 14 forks source link

chore: Split semantic-release out to a separate job #30

Closed cameronwaterman closed 1 year ago

cameronwaterman commented 1 year ago

What does this Pull Request accomplish?

Splits the semantic-release step out to a separate job. The "build" step currently runs against a matrix of Python versions and we don't want to run the semantic-release tool multiple times.

Why should this Pull Request be merged?

Avoids an issue where we would attempt to build 4 releases per submission.

What testing has been done?

Commented out the conditional on the new job and verified it attempts to build a release (once): https://github.com/ni/nisystemlink-clients-python/actions/runs/3482629028/jobs/5825222594

Current PR build shows that the job is skipped with the conditional uncommented.

cameronwaterman commented 1 year ago

Question that didn't occur to me before, does python-semantic-release automatically detect that this is a poetry project? How does it know what commands to run (e.g. poetry build)?

It's in the pyproject.toml config https://github.com/ni/nisystemlink-clients-python/blob/master/pyproject.toml#L71

mure commented 1 year ago

It's in the pyproject.toml config https://github.com/ni/nisystemlink-clients-python/blob/master/pyproject.toml#L71

Ah yes, I remember seeing this. I was looking for a separate config file.