search

ni / nisystemlink-clients-python

Python API for interacting with a SystemLink Server, created and supported by NI.
https://ni.com/systemlink
MIT License
10 stars 14 forks source link

fix: Commit message validation #43

Closed cameronwaterman closed 11 months ago

cameronwaterman commented 1 year ago

What does this Pull Request accomplish?

Adds validation that commit messages adhere to the Angular style.

This commit would generally have a "build" or "ci" prefix type, but we need to force a version and rebuild as https://github.com/ni/nisystemlink-clients-python/commit/7881a90c7fcfc5dd88228d171f8000b10330b04f did not result in a new version being built.

Why should this Pull Request be merged?

Ensure we have properly formatted commit messages.

What testing has been done?

See PR build.

cameronwaterman commented 1 year ago

It looks like if you want the commit message validation step to run against an updated PR title you have to push another commit. Not sure if this is something we want to require for this repo.

mure commented 1 year ago

It looks like if you want the commit message validation step to run against an updated PR title you have to push another commit. Not sure if this is something we want to require for this repo.

If this is the case, I think it's too cumbersome to enable this check.

spanglerco commented 1 year ago

It looks like if you want the commit message validation step to run against an updated PR title you have to push another commit. Not sure if this is something we want to require for this repo.

How about https://github.com/aslafy-z/conventional-pr-title-action/issues/165#issuecomment-1066634563?

cameronwaterman commented 1 year ago

It looks like if you want the commit message validation step to run against an updated PR title you have to push another commit. Not sure if this is something we want to require for this repo.

How about aslafy-z/conventional-pr-title-action#165 (comment)?

Interesting. Applying that change did rerun the workflow on the new commit, but after changing the PR title the PR check is gone completely.