ni / niveristand-aim-milStd1553-custom-device

Custom device for AIM MIL-STD-1553 hardware
MIT License
1 stars 2 forks source link

Clean up Hardware API, set up deployment tests #17

Closed papowerNI closed 2 years ago

papowerNI commented 2 years ago

What does this Pull Request accomplish?

Add Initialize 1553 Module to the Hardware API, go through Hardware API VIs and clean up VIs to have consistent I/O. Re-enables deployment tests that should currently work with the correct setup (AIM instead of Ballard)

Why should this Pull Request be merged?

Just cleanup. Precursor to adding PXI slot and any other Initialize todos, to keep future PRs smaller and less error prone.

What testing has been done?

tests still run, manually deploying and read/write still works. Also ran automated tests: image

niveristand-diff-bot commented 2 years ago

Bleep bloop!

LabVIEW Diff Robot here with some diffs served up hot for your pull request.

Notice something funny? Help fix me on my GitHub repo.

AIM MIL-STD-1553 Hardware API.lvlib--Configure Major Frame.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-aim-milStd1553-custom-device/PR-17/2022-05-16/08%3A58%3A25/AIM%20MIL-STD-1553%20Hardware%20API.lvlib--Configure%20Major%20Frame.vi.png)
AIM MIL-STD-1553 Hardware API.lvlib--Configure Minor Frame.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-aim-milStd1553-custom-device/PR-17/2022-05-16/08%3A58%3A25/AIM%20MIL-STD-1553%20Hardware%20API.lvlib--Configure%20Minor%20Frame.vi.png)
AIM MIL-STD-1553 Hardware API.lvlib--Configure Simple Frame.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-aim-milStd1553-custom-device/PR-17/2022-05-16/08%3A58%3A25/AIM%20MIL-STD-1553%20Hardware%20API.lvlib--Configure%20Simple%20Frame.vi.png)
AIM MIL-STD-1553 Hardware API.lvlib--Create BC Transfer and Buffer.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-aim-milStd1553-custom-device/PR-17/2022-05-16/08%3A58%3A25/AIM%20MIL-STD-1553%20Hardware%20API.lvlib--Create%20BC%20Transfer%20and%20Buffer.vi.png)
AIM MIL-STD-1553 Hardware API.lvlib--Initialize 1553 Driver.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-aim-milStd1553-custom-device/PR-17/2022-05-16/08%3A58%3A25/AIM%20MIL-STD-1553%20Hardware%20API.lvlib--Initialize%201553%20Driver.vi.png)
AIM MIL-STD-1553 Hardware API.lvlib--Initialize 1553 Module.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-aim-milStd1553-custom-device/PR-17/2022-05-16/08%3A58%3A25/AIM%20MIL-STD-1553%20Hardware%20API.lvlib--Initialize%201553%20Module.vi.png)
AIM MIL-STD-1553 Hardware API.lvlib--Initialize Bus Controller.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-aim-milStd1553-custom-device/PR-17/2022-05-16/08%3A58%3A25/AIM%20MIL-STD-1553%20Hardware%20API.lvlib--Initialize%20Bus%20Controller.vi.png)
AIM MIL-STD-1553 Hardware API.lvlib--Initialize RT.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-aim-milStd1553-custom-device/PR-17/2022-05-16/08%3A58%3A25/AIM%20MIL-STD-1553%20Hardware%20API.lvlib--Initialize%20RT.vi.png)
AIM MIL-STD-1553 Hardware API.lvlib--Initialize Subaddress.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-aim-milStd1553-custom-device/PR-17/2022-05-16/08%3A58%3A25/AIM%20MIL-STD-1553%20Hardware%20API.lvlib--Initialize%20Subaddress.vi.png)
AIM MIL-STD-1553 Hardware API.lvlib--Read Buffer.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-aim-milStd1553-custom-device/PR-17/2022-05-16/08%3A58%3A25/AIM%20MIL-STD-1553%20Hardware%20API.lvlib--Read%20Buffer.vi.png)
AIM MIL-STD-1553 Hardware API.lvlib--Read Global Message Count.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-aim-milStd1553-custom-device/PR-17/2022-05-16/08%3A58%3A25/AIM%20MIL-STD-1553%20Hardware%20API.lvlib--Read%20Global%20Message%20Count.vi.png)
AIM MIL-STD-1553 Hardware API.lvlib--Set Device Coupling.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-aim-milStd1553-custom-device/PR-17/2022-05-16/08%3A58%3A25/AIM%20MIL-STD-1553%20Hardware%20API.lvlib--Set%20Device%20Coupling.vi.png)
AIM MIL-STD-1553 Hardware API.lvlib--Start All.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-aim-milStd1553-custom-device/PR-17/2022-05-16/08%3A58%3A25/AIM%20MIL-STD-1553%20Hardware%20API.lvlib--Start%20All.vi.png)
AIM MIL-STD-1553 Hardware API.lvlib--Stop All.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-aim-milStd1553-custom-device/PR-17/2022-05-16/08%3A58%3A25/AIM%20MIL-STD-1553%20Hardware%20API.lvlib--Stop%20All.vi.png)
AIM MIL-STD-1553 Hardware API.lvlib--Write All Data Words.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-aim-milStd1553-custom-device/PR-17/2022-05-16/08%3A58%3A25/AIM%20MIL-STD-1553%20Hardware%20API.lvlib--Write%20All%20Data%20Words.vi.png)
AIM MIL-STD-1553 Hardware API.lvlib--Write Data Word.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-aim-milStd1553-custom-device/PR-17/2022-05-16/08%3A58%3A25/AIM%20MIL-STD-1553%20Hardware%20API.lvlib--Write%20Data%20Word.vi.png)
Deployment.lvclass--test Deployment Import BC-Only Configuration.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-aim-milStd1553-custom-device/PR-17/2022-05-16/08%3A58%3A25/Deployment.lvclass--test%20Deployment%20Import%20BC-Only%20Configuration.vi.png)
Deployment.lvclass--test Deployment Import Configuration.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-aim-milStd1553-custom-device/PR-17/2022-05-16/08%3A58%3A25/Deployment.lvclass--test%20Deployment%20Import%20Configuration.vi.png)
Deployment.lvclass--test Deployment Import RT-Only Configuration.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-aim-milStd1553-custom-device/PR-17/2022-05-16/08%3A58%3A25/Deployment.lvclass--test%20Deployment%20Import%20RT-Only%20Configuration.vi.png)