search

ni / niveristand-aim-milStd1553-custom-device

Custom device for AIM MIL-STD-1553 hardware
MIT License
1 stars 2 forks source link

consolidate the shared resources initialize functions #26

Closed papowerNI closed 2 years ago

papowerNI commented 2 years ago

What does this Pull Request accomplish?

Some of the Shared Resources-specific subVIs are in the general Engine.lvlib for some reason, so I moved them to within shared resources for clarity. Also removed unnecessary controls from intialize hardware, and cleaned up some naming.

Why should this Pull Request be merged?

clean up in separate PRs keeps future PRs readable.

What testing has been done?

built and manually tested, basic read/write still works.

niveristand-diff-bot commented 2 years ago

Bleep bloop!

LabVIEW Diff Robot here with some diffs served up hot for your pull request.

Notice something funny? Help fix me on my GitHub repo.

AIM MIL-STD-1553 Engine.lvlib--Implementation.lvlib--Shared Resources.lvclass--Construct.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-aim-milStd1553-custom-device/PR-26/2022-05-24/14%3A22%3A15/AIM%20MIL-STD-1553%20Engine.lvlib--Implementation.lvlib--Shared%20Resources.lvclass--Construct.vi.png)
AIM MIL-STD-1553 Engine.lvlib--Implementation.lvlib--Shared Resources.lvclass--Finalize.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-aim-milStd1553-custom-device/PR-26/2022-05-24/14%3A22%3A15/AIM%20MIL-STD-1553%20Engine.lvlib--Implementation.lvlib--Shared%20Resources.lvclass--Finalize.vi.png)
AIM MIL-STD-1553 Engine.lvlib--Implementation.lvlib--Shared Resources.lvclass--Initialize Bus Controller.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-aim-milStd1553-custom-device/PR-26/2022-05-24/14%3A22%3A15/AIM%20MIL-STD-1553%20Engine.lvlib--Implementation.lvlib--Shared%20Resources.lvclass--Initialize%20Bus%20Controller.vi.png)
AIM MIL-STD-1553 Engine.lvlib--Implementation.lvlib--Shared Resources.lvclass--Initialize Hardware.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-aim-milStd1553-custom-device/PR-26/2022-05-24/14%3A22%3A15/AIM%20MIL-STD-1553%20Engine.lvlib--Implementation.lvlib--Shared%20Resources.lvclass--Initialize%20Hardware.vi.png)
AIM MIL-STD-1553 Engine.lvlib--Implementation.lvlib--Shared Resources.lvclass--Initialize Logging.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-aim-milStd1553-custom-device/PR-26/2022-05-24/14%3A22%3A15/AIM%20MIL-STD-1553%20Engine.lvlib--Implementation.lvlib--Shared%20Resources.lvclass--Initialize%20Logging.vi.png)
AIM MIL-STD-1553 Engine.lvlib--Implementation.lvlib--Shared Resources.lvclass--Initialize Remote Terminals.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-aim-milStd1553-custom-device/PR-26/2022-05-24/14%3A22%3A15/AIM%20MIL-STD-1553%20Engine.lvlib--Implementation.lvlib--Shared%20Resources.lvclass--Initialize%20Remote%20Terminals.vi.png)
AIM MIL-STD-1553 Engine.lvlib--Implementation.lvlib--Shared Resources.lvclass--Initialize.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-aim-milStd1553-custom-device/PR-26/2022-05-24/14%3A22%3A15/AIM%20MIL-STD-1553%20Engine.lvlib--Implementation.lvlib--Shared%20Resources.lvclass--Initialize.vi.png)
AIM MIL-STD-1553 Engine.lvlib--Implementation.lvlib--Shared Resources.lvclass--Read BC Subaddress to Buffer ID Map.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-aim-milStd1553-custom-device/PR-26/2022-05-24/14%3A22%3A15/AIM%20MIL-STD-1553%20Engine.lvlib--Implementation.lvlib--Shared%20Resources.lvclass--Read%20BC%20Subaddress%20to%20Buffer%20ID%20Map.vi.png)
AIM MIL-STD-1553 Engine.lvlib--Implementation.lvlib--Shared Resources.lvclass--Read Log Producer.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-aim-milStd1553-custom-device/PR-26/2022-05-24/14%3A22%3A15/AIM%20MIL-STD-1553%20Engine.lvlib--Implementation.lvlib--Shared%20Resources.lvclass--Read%20Log%20Producer.vi.png)
AIM MIL-STD-1553 Engine.lvlib--Implementation.lvlib--Shared Resources.lvclass--Read Module Reference.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-aim-milStd1553-custom-device/PR-26/2022-05-24/14%3A22%3A15/AIM%20MIL-STD-1553%20Engine.lvlib--Implementation.lvlib--Shared%20Resources.lvclass--Read%20Module%20Reference.vi.png)
AIM MIL-STD-1553 Engine.lvlib--Implementation.lvlib--Shared Resources.lvclass--Read RT Subaddress to Buffer ID Map.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-aim-milStd1553-custom-device/PR-26/2022-05-24/14%3A22%3A15/AIM%20MIL-STD-1553%20Engine.lvlib--Implementation.lvlib--Shared%20Resources.lvclass--Read%20RT%20Subaddress%20to%20Buffer%20ID%20Map.vi.png)
niveristand-diff-bot commented 2 years ago

Bleep bloop!

LabVIEW Diff Robot here with some diffs served up hot for your pull request.

Notice something funny? Help fix me on my GitHub repo.

AIM MIL-STD-1553 Engine.lvlib--Implementation.lvlib--Shared Resources.lvclass--Construct.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-aim-milStd1553-custom-device/PR-26/2022-05-25/10%3A22%3A33/AIM%20MIL-STD-1553%20Engine.lvlib--Implementation.lvlib--Shared%20Resources.lvclass--Construct.vi.png)
AIM MIL-STD-1553 Engine.lvlib--Implementation.lvlib--Shared Resources.lvclass--Finalize.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-aim-milStd1553-custom-device/PR-26/2022-05-25/10%3A22%3A33/AIM%20MIL-STD-1553%20Engine.lvlib--Implementation.lvlib--Shared%20Resources.lvclass--Finalize.vi.png)
AIM MIL-STD-1553 Engine.lvlib--Implementation.lvlib--Shared Resources.lvclass--Initialize Bus Controller.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-aim-milStd1553-custom-device/PR-26/2022-05-25/10%3A22%3A33/AIM%20MIL-STD-1553%20Engine.lvlib--Implementation.lvlib--Shared%20Resources.lvclass--Initialize%20Bus%20Controller.vi.png)
AIM MIL-STD-1553 Engine.lvlib--Implementation.lvlib--Shared Resources.lvclass--Initialize Hardware.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-aim-milStd1553-custom-device/PR-26/2022-05-25/10%3A22%3A33/AIM%20MIL-STD-1553%20Engine.lvlib--Implementation.lvlib--Shared%20Resources.lvclass--Initialize%20Hardware.vi.png)
AIM MIL-STD-1553 Engine.lvlib--Implementation.lvlib--Shared Resources.lvclass--Initialize Logging.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-aim-milStd1553-custom-device/PR-26/2022-05-25/10%3A22%3A33/AIM%20MIL-STD-1553%20Engine.lvlib--Implementation.lvlib--Shared%20Resources.lvclass--Initialize%20Logging.vi.png)
AIM MIL-STD-1553 Engine.lvlib--Implementation.lvlib--Shared Resources.lvclass--Initialize Remote Terminals.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-aim-milStd1553-custom-device/PR-26/2022-05-25/10%3A22%3A33/AIM%20MIL-STD-1553%20Engine.lvlib--Implementation.lvlib--Shared%20Resources.lvclass--Initialize%20Remote%20Terminals.vi.png)
AIM MIL-STD-1553 Engine.lvlib--Implementation.lvlib--Shared Resources.lvclass--Initialize.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-aim-milStd1553-custom-device/PR-26/2022-05-25/10%3A22%3A33/AIM%20MIL-STD-1553%20Engine.lvlib--Implementation.lvlib--Shared%20Resources.lvclass--Initialize.vi.png)
AIM MIL-STD-1553 Engine.lvlib--Implementation.lvlib--Shared Resources.lvclass--Read BC Subaddress to Buffer ID Map.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-aim-milStd1553-custom-device/PR-26/2022-05-25/10%3A22%3A33/AIM%20MIL-STD-1553%20Engine.lvlib--Implementation.lvlib--Shared%20Resources.lvclass--Read%20BC%20Subaddress%20to%20Buffer%20ID%20Map.vi.png)
AIM MIL-STD-1553 Engine.lvlib--Implementation.lvlib--Shared Resources.lvclass--Read Log Producer.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-aim-milStd1553-custom-device/PR-26/2022-05-25/10%3A22%3A33/AIM%20MIL-STD-1553%20Engine.lvlib--Implementation.lvlib--Shared%20Resources.lvclass--Read%20Log%20Producer.vi.png)
AIM MIL-STD-1553 Engine.lvlib--Implementation.lvlib--Shared Resources.lvclass--Read Module Reference.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-aim-milStd1553-custom-device/PR-26/2022-05-25/10%3A22%3A33/AIM%20MIL-STD-1553%20Engine.lvlib--Implementation.lvlib--Shared%20Resources.lvclass--Read%20Module%20Reference.vi.png)
AIM MIL-STD-1553 Engine.lvlib--Implementation.lvlib--Shared Resources.lvclass--Read RT Subaddress to Buffer ID Map.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-aim-milStd1553-custom-device/PR-26/2022-05-25/10%3A22%3A33/AIM%20MIL-STD-1553%20Engine.lvlib--Implementation.lvlib--Shared%20Resources.lvclass--Read%20RT%20Subaddress%20to%20Buffer%20ID%20Map.vi.png)