search

ni / niveristand-aim-milStd1553-custom-device

Custom device for AIM MIL-STD-1553 hardware
MIT License
1 stars 2 forks source link

Add RT Driver error logging #29

Closed papowerNI closed 2 years ago

papowerNI commented 2 years ago

What does this Pull Request accomplish?

Add a conditional VI that will log an error that occurs in the engine to the Veristand Log so that more than just the error code can be recovered when an error is encountered in the engine.

Why should this Pull Request be merged?

If no errors occur (which should be the norm), this will skip all added behavior -- otherwise, it should allow for quicker troubleshooting during development or when unexpected error occur from the AIM api or elsewhere.

What testing has been done?

Tried adding an error that would ordinarily say a generic "parameter missing" by including unsupported xml: image The specific part of the xml is now identifiable.

Here's what is shown from Veristand (not really useful) because error handling has not been added yet with custom error codes: image

Also tested with no errors, and nothing weird shows up in the logs since case structure is skipped: image

niveristand-diff-bot commented 2 years ago

Bleep bloop!

LabVIEW Diff Robot here with some diffs served up hot for your pull request.

Notice something funny? Help fix me on my GitHub repo.

AIM MIL-STD-1553 Engine.lvlib--Custom Device.lvlib--Log RT Driver Error.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-aim-milStd1553-custom-device/PR-29/2022-06-01/16%3A31%3A41/AIM%20MIL-STD-1553%20Engine.lvlib--Custom%20Device.lvlib--Log%20RT%20Driver%20Error.vi.png)
AIM MIL-STD-1553 Engine.lvlib--Custom Device.lvlib--RT Driver VI.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-aim-milStd1553-custom-device/PR-29/2022-06-01/16%3A31%3A41/AIM%20MIL-STD-1553%20Engine.lvlib--Custom%20Device.lvlib--RT%20Driver%20VI.vi.png)