search

ni / niveristand-aim-milStd1553-custom-device

Custom device for AIM MIL-STD-1553 hardware
MIT License
1 stars 2 forks source link

deballardize Docs/error list, and fix empty param file errors with single port #31

Closed papowerNI closed 2 years ago

papowerNI commented 2 years ago

What does this Pull Request accomplish?

  1. change the Ballard error codes to AIM 1553 error codes(leaving 100 error codes for AIM 429)
  2. add conditional structures for finding a port when none is available. Previously code was skipped implicitly by an empty array going into a for loop, but now it is not.
  3. Updated the error code for adding a port when one already exists.

Why should this Pull Request be merged?

clean up and error message updates are needed for initial release.

What testing has been done?

Tested adding an empty parameter file, saw no issues. Also ran automated tests.

niveristand-diff-bot commented 2 years ago

Bleep bloop!

LabVIEW Diff Robot here with some diffs served up hot for your pull request.

Notice something funny? Help fix me on my GitHub repo.

AIM MIL-STD-1553 Scripting.lvlib--Add Port.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-aim-milStd1553-custom-device/PR-31/2022-06-02/22%3A34%3A32/AIM%20MIL-STD-1553%20Scripting.lvlib--Add%20Port.vi.png)
AIM MIL-STD-1553 Scripting.lvlib--Get Port.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-aim-milStd1553-custom-device/PR-31/2022-06-02/22%3A34%3A32/AIM%20MIL-STD-1553%20Scripting.lvlib--Get%20Port.vi.png)
AIM MIL-STD-1553 Scripting.lvlib--Import Configuration File.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-aim-milStd1553-custom-device/PR-31/2022-06-02/22%3A34%3A32/AIM%20MIL-STD-1553%20Scripting.lvlib--Import%20Configuration%20File.vi.png)
AIM MIL-STD-1553 Scripting.lvlib--Read Configuration.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-aim-milStd1553-custom-device/PR-31/2022-06-02/22%3A34%3A32/AIM%20MIL-STD-1553%20Scripting.lvlib--Read%20Configuration.vi.png)
AIM MIL-STD-1553 Scripting.lvlib--Remove Port.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-aim-milStd1553-custom-device/PR-31/2022-06-02/22%3A34%3A32/AIM%20MIL-STD-1553%20Scripting.lvlib--Remove%20Port.vi.png)
AIM MIL-STD-1553 Scripting.lvlib--Write Configuration.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-aim-milStd1553-custom-device/PR-31/2022-06-02/22%3A34%3A32/AIM%20MIL-STD-1553%20Scripting.lvlib--Write%20Configuration.vi.png)
AIM MIL-STD-1553 System Explorer.lvlib--Implementation.lvlib--Refresh.lvlib--Handle Parameter Configuration File Change.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-aim-milStd1553-custom-device/PR-31/2022-06-02/22%3A34%3A32/AIM%20MIL-STD-1553%20System%20Explorer.lvlib--Implementation.lvlib--Refresh.lvlib--Handle%20Parameter%20Configuration%20File%20Change.vi.png)
niveristand-diff-bot commented 2 years ago

Bleep bloop!

LabVIEW Diff Robot here with some diffs served up hot for your pull request.

Notice something funny? Help fix me on my GitHub repo.

AIM MIL-STD-1553 Scripting.lvlib--Add Port.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-aim-milStd1553-custom-device/PR-31/2022-06-03/09%3A34%3A14/AIM%20MIL-STD-1553%20Scripting.lvlib--Add%20Port.vi.png)
AIM MIL-STD-1553 Scripting.lvlib--Import Configuration File.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-aim-milStd1553-custom-device/PR-31/2022-06-03/09%3A34%3A14/AIM%20MIL-STD-1553%20Scripting.lvlib--Import%20Configuration%20File.vi.png)
AIM MIL-STD-1553 Scripting.lvlib--Read Configuration.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-aim-milStd1553-custom-device/PR-31/2022-06-03/09%3A34%3A14/AIM%20MIL-STD-1553%20Scripting.lvlib--Read%20Configuration.vi.png)
AIM MIL-STD-1553 Scripting.lvlib--Remove Port.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-aim-milStd1553-custom-device/PR-31/2022-06-03/09%3A34%3A14/AIM%20MIL-STD-1553%20Scripting.lvlib--Remove%20Port.vi.png)
AIM MIL-STD-1553 Scripting.lvlib--Write Configuration.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-aim-milStd1553-custom-device/PR-31/2022-06-03/09%3A34%3A14/AIM%20MIL-STD-1553%20Scripting.lvlib--Write%20Configuration.vi.png)
AIM MIL-STD-1553 System Explorer.lvlib--Implementation.lvlib--Refresh.lvlib--Handle Parameter Configuration File Change.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-aim-milStd1553-custom-device/PR-31/2022-06-03/09%3A34%3A14/AIM%20MIL-STD-1553%20System%20Explorer.lvlib--Implementation.lvlib--Refresh.lvlib--Handle%20Parameter%20Configuration%20File%20Change.vi.png)