search

ni / niveristand-aim-milStd1553-custom-device

Custom device for AIM MIL-STD-1553 hardware
MIT License
1 stars 2 forks source link

Remove status error channels #33

Closed papowerNI closed 2 years ago

papowerNI commented 2 years ago

What does this Pull Request accomplish?

Removes the status error channels that are artifacts leftover from the Ballard version of this custom device.

Why should this Pull Request be merged?

Removing status channels is part of the initial release. Removing them now alleviates any need to worry about them as implementing other features on this custom device.

What testing has been done?

Manually built and deployed custom device, and ran automated tests. Status channels are no longer generated: image

niveristand-diff-bot commented 2 years ago

Bleep bloop!

LabVIEW Diff Robot here with some diffs served up hot for your pull request.

Notice something funny? Help fix me on my GitHub repo.

AIM MIL-STD-1553 Engine.lvlib--Implementation.lvlib--Execution Unit Factory.lvclass--Create Execution Unit.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-aim-milStd1553-custom-device/PR-33/2022-06-06/17%3A31%3A54/AIM%20MIL-STD-1553%20Engine.lvlib--Implementation.lvlib--Execution%20Unit%20Factory.lvclass--Create%20Execution%20Unit.vi.png)
AIM MIL-STD-1553 Engine.lvlib--Implementation.lvlib--Execution Unit.lvclass--Channel Handles Hierarchy to Channels Array.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-aim-milStd1553-custom-device/PR-33/2022-06-06/17%3A31%3A54/AIM%20MIL-STD-1553%20Engine.lvlib--Implementation.lvlib--Execution%20Unit.lvclass--Channel%20Handles%20Hierarchy%20to%20Channels%20Array.vi.png)
AIM MIL-STD-1553 Engine.lvlib--Implementation.lvlib--Execution Unit.lvclass--Construct.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-aim-milStd1553-custom-device/PR-33/2022-06-06/17%3A31%3A54/AIM%20MIL-STD-1553%20Engine.lvlib--Implementation.lvlib--Execution%20Unit.lvclass--Construct.vi.png)
AIM MIL-STD-1553 Engine.lvlib--Implementation.lvlib--Execution Unit.lvclass--Read 1553 Channel Handles.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-aim-milStd1553-custom-device/PR-33/2022-06-06/17%3A31%3A54/AIM%20MIL-STD-1553%20Engine.lvlib--Implementation.lvlib--Execution%20Unit.lvclass--Read%201553%20Channel%20Handles.vi.png)
AIM MIL-STD-1553 Engine.lvlib--Implementation.lvlib--Logging Execution Unit.lvclass--Logging Construct.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-aim-milStd1553-custom-device/PR-33/2022-06-06/17%3A31%3A54/AIM%20MIL-STD-1553%20Engine.lvlib--Implementation.lvlib--Logging%20Execution%20Unit.lvclass--Logging%20Construct.vi.png)
AIM MIL-STD-1553 Engine.lvlib--Implementation.lvlib--Rx Execution Unit.lvclass--Create Map from Messages to Value Indexes.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-aim-milStd1553-custom-device/PR-33/2022-06-06/17%3A31%3A54/AIM%20MIL-STD-1553%20Engine.lvlib--Implementation.lvlib--Rx%20Execution%20Unit.lvclass--Create%20Map%20from%20Messages%20to%20Value%20Indexes.vi.png)
AIM MIL-STD-1553 Engine.lvlib--Implementation.lvlib--Rx Execution Unit.lvclass--Rx Construct.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-aim-milStd1553-custom-device/PR-33/2022-06-06/17%3A31%3A54/AIM%20MIL-STD-1553%20Engine.lvlib--Implementation.lvlib--Rx%20Execution%20Unit.lvclass--Rx%20Construct.vi.png)
AIM MIL-STD-1553 Engine.lvlib--Implementation.lvlib--Tx Execution Unit.lvclass--Create Map from Message Indexes to Tx Write Info.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-aim-milStd1553-custom-device/PR-33/2022-06-06/17%3A31%3A54/AIM%20MIL-STD-1553%20Engine.lvlib--Implementation.lvlib--Tx%20Execution%20Unit.lvclass--Create%20Map%20from%20Message%20Indexes%20to%20Tx%20Write%20Info.vi.png)
AIM MIL-STD-1553 Engine.lvlib--Implementation.lvlib--Tx Execution Unit.lvclass--Tx Construct.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-aim-milStd1553-custom-device/PR-33/2022-06-06/17%3A31%3A54/AIM%20MIL-STD-1553%20Engine.lvlib--Implementation.lvlib--Tx%20Execution%20Unit.lvclass--Tx%20Construct.vi.png)
AIM MIL-STD-1553 Scripting.lvlib--Add Configuration Files Section.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-aim-milStd1553-custom-device/PR-33/2022-06-06/17%3A31%3A54/AIM%20MIL-STD-1553%20Scripting.lvlib--Add%20Configuration%20Files%20Section.vi.png)
AIM MIL-STD-1553 Scripting.lvlib--Initialize Custom Device.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-aim-milStd1553-custom-device/PR-33/2022-06-06/17%3A31%3A54/AIM%20MIL-STD-1553%20Scripting.lvlib--Initialize%20Custom%20Device.vi.png)
AIM MIL-STD-1553 System Explorer.lvlib--Implementation.lvlib--Initialize.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-aim-milStd1553-custom-device/PR-33/2022-06-06/17%3A31%3A54/AIM%20MIL-STD-1553%20System%20Explorer.lvlib--Implementation.lvlib--Initialize.vi.png)
AIM MIL-STD-1553 System Explorer.lvlib--Implementation.lvlib--System Explorer Dispatcher.lvclass--Build Map from Page GUIDs to Page VIs.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-aim-milStd1553-custom-device/PR-33/2022-06-06/17%3A31%3A54/AIM%20MIL-STD-1553%20System%20Explorer.lvlib--Implementation.lvlib--System%20Explorer%20Dispatcher.lvclass--Build%20Map%20from%20Page%20GUIDs%20to%20Page%20VIs.vi.png)
Engine.lvclass--test Create Map from Messages to Value Indexes.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-aim-milStd1553-custom-device/PR-33/2022-06-06/17%3A31%3A54/Engine.lvclass--test%20Create%20Map%20from%20Messages%20to%20Value%20Indexes.vi.png)
Scripting.lvclass--test Add-Find-Remove.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-aim-milStd1553-custom-device/PR-33/2022-06-06/17%3A31%3A54/Scripting.lvclass--test%20Add-Find-Remove.vi.png)
niveristand-diff-bot commented 2 years ago

Bleep bloop!

LabVIEW Diff Robot here with some diffs served up hot for your pull request.

Notice something funny? Help fix me on my GitHub repo.

AIM MIL-STD-1553 Engine.lvlib--Implementation.lvlib--Execution Unit Factory.lvclass--Create Execution Unit.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-aim-milStd1553-custom-device/PR-33/2022-06-07/16%3A31%3A49/AIM%20MIL-STD-1553%20Engine.lvlib--Implementation.lvlib--Execution%20Unit%20Factory.lvclass--Create%20Execution%20Unit.vi.png)
AIM MIL-STD-1553 Engine.lvlib--Implementation.lvlib--Execution Unit.lvclass--Channel Handles Hierarchy to Channels Array.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-aim-milStd1553-custom-device/PR-33/2022-06-07/16%3A31%3A49/AIM%20MIL-STD-1553%20Engine.lvlib--Implementation.lvlib--Execution%20Unit.lvclass--Channel%20Handles%20Hierarchy%20to%20Channels%20Array.vi.png)
AIM MIL-STD-1553 Engine.lvlib--Implementation.lvlib--Execution Unit.lvclass--Construct.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-aim-milStd1553-custom-device/PR-33/2022-06-07/16%3A31%3A49/AIM%20MIL-STD-1553%20Engine.lvlib--Implementation.lvlib--Execution%20Unit.lvclass--Construct.vi.png)
AIM MIL-STD-1553 Engine.lvlib--Implementation.lvlib--Execution Unit.lvclass--Read 1553 Channel Handles.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-aim-milStd1553-custom-device/PR-33/2022-06-07/16%3A31%3A49/AIM%20MIL-STD-1553%20Engine.lvlib--Implementation.lvlib--Execution%20Unit.lvclass--Read%201553%20Channel%20Handles.vi.png)
AIM MIL-STD-1553 Engine.lvlib--Implementation.lvlib--Logging Execution Unit.lvclass--Logging Construct.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-aim-milStd1553-custom-device/PR-33/2022-06-07/16%3A31%3A49/AIM%20MIL-STD-1553%20Engine.lvlib--Implementation.lvlib--Logging%20Execution%20Unit.lvclass--Logging%20Construct.vi.png)
AIM MIL-STD-1553 Engine.lvlib--Implementation.lvlib--Rx Execution Unit.lvclass--Create Map from Messages to Value Indexes.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-aim-milStd1553-custom-device/PR-33/2022-06-07/16%3A31%3A49/AIM%20MIL-STD-1553%20Engine.lvlib--Implementation.lvlib--Rx%20Execution%20Unit.lvclass--Create%20Map%20from%20Messages%20to%20Value%20Indexes.vi.png)
AIM MIL-STD-1553 Engine.lvlib--Implementation.lvlib--Rx Execution Unit.lvclass--Rx Construct.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-aim-milStd1553-custom-device/PR-33/2022-06-07/16%3A31%3A49/AIM%20MIL-STD-1553%20Engine.lvlib--Implementation.lvlib--Rx%20Execution%20Unit.lvclass--Rx%20Construct.vi.png)
AIM MIL-STD-1553 Engine.lvlib--Implementation.lvlib--Tx Execution Unit.lvclass--Create Map from Message Indexes to Tx Write Info.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-aim-milStd1553-custom-device/PR-33/2022-06-07/16%3A31%3A49/AIM%20MIL-STD-1553%20Engine.lvlib--Implementation.lvlib--Tx%20Execution%20Unit.lvclass--Create%20Map%20from%20Message%20Indexes%20to%20Tx%20Write%20Info.vi.png)
AIM MIL-STD-1553 Engine.lvlib--Implementation.lvlib--Tx Execution Unit.lvclass--Tx Construct.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-aim-milStd1553-custom-device/PR-33/2022-06-07/16%3A31%3A49/AIM%20MIL-STD-1553%20Engine.lvlib--Implementation.lvlib--Tx%20Execution%20Unit.lvclass--Tx%20Construct.vi.png)
AIM MIL-STD-1553 Scripting.lvlib--Add Configuration Files Section.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-aim-milStd1553-custom-device/PR-33/2022-06-07/16%3A31%3A49/AIM%20MIL-STD-1553%20Scripting.lvlib--Add%20Configuration%20Files%20Section.vi.png)
AIM MIL-STD-1553 Scripting.lvlib--Constants.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-aim-milStd1553-custom-device/PR-33/2022-06-07/16%3A31%3A49/AIM%20MIL-STD-1553%20Scripting.lvlib--Constants.vi.png)
AIM MIL-STD-1553 Scripting.lvlib--Initialize Custom Device.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-aim-milStd1553-custom-device/PR-33/2022-06-07/16%3A31%3A49/AIM%20MIL-STD-1553%20Scripting.lvlib--Initialize%20Custom%20Device.vi.png)
AIM MIL-STD-1553 System Explorer.lvlib--Implementation.lvlib--Initialize.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-aim-milStd1553-custom-device/PR-33/2022-06-07/16%3A31%3A49/AIM%20MIL-STD-1553%20System%20Explorer.lvlib--Implementation.lvlib--Initialize.vi.png)
AIM MIL-STD-1553 System Explorer.lvlib--Implementation.lvlib--System Explorer Dispatcher.lvclass--Build Map from Page GUIDs to Page VIs.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-aim-milStd1553-custom-device/PR-33/2022-06-07/16%3A31%3A49/AIM%20MIL-STD-1553%20System%20Explorer.lvlib--Implementation.lvlib--System%20Explorer%20Dispatcher.lvclass--Build%20Map%20from%20Page%20GUIDs%20to%20Page%20VIs.vi.png)
Engine.lvclass--test Create Map from Messages to Value Indexes.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-aim-milStd1553-custom-device/PR-33/2022-06-07/16%3A31%3A49/Engine.lvclass--test%20Create%20Map%20from%20Messages%20to%20Value%20Indexes.vi.png)
Scripting.lvclass--test Add-Find-Remove.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-aim-milStd1553-custom-device/PR-33/2022-06-07/16%3A31%3A49/Scripting.lvclass--test%20Add-Find-Remove.vi.png)