ni / niveristand-aim-milStd1553-custom-device

Custom device for AIM MIL-STD-1553 hardware
MIT License
1 stars 2 forks source link

Update error codes to AIM codes #34

Closed papowerNI closed 2 years ago

papowerNI commented 2 years ago

What does this Pull Request accomplish?

Replaces error codes that are in the Ballard 1553 range with codes for AIM 1553. Note: One of the error codes is in a malleable VI that required several VIs to be resaved.

Why should this Pull Request be merged?

Error codes are currently for the wrong custom device

What testing has been done?

Ran unit tests, manually opened, deployed, and tried to get one of the errors.

niveristand-diff-bot commented 2 years ago

Bleep bloop!

LabVIEW Diff Robot here with some diffs served up hot for your pull request.

Notice something funny? Help fix me on my GitHub repo.

1553 Parameters Import.lvclass--test Import Error when No Channels.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-aim-milStd1553-custom-device/PR-34/2022-06-07/14%3A51%3A05/1553%20Parameters%20Import.lvclass--test%20Import%20Error%20when%20No%20Channels.vi.png)
1553 Parameters Import.lvclass--test Import with Parameters Files Missing Something.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-aim-milStd1553-custom-device/PR-34/2022-06-07/14%3A51%3A05/1553%20Parameters%20Import.lvclass--test%20Import%20with%20Parameters%20Files%20Missing%20Something.vi.png)
AIM MIL-STD-1553 Engine.lvlib--Implementation.lvlib--CSV Word Logger.lvclass--Open Log File.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-aim-milStd1553-custom-device/PR-34/2022-06-07/14%3A51%3A05/AIM%20MIL-STD-1553%20Engine.lvlib--Implementation.lvlib--CSV%20Word%20Logger.lvclass--Open%20Log%20File.vi.png)
AIM MIL-STD-1553 Engine.lvlib--Implementation.lvlib--CSV Word Logger.lvclass--Write Logged Data.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-aim-milStd1553-custom-device/PR-34/2022-06-07/14%3A51%3A05/AIM%20MIL-STD-1553%20Engine.lvlib--Implementation.lvlib--CSV%20Word%20Logger.lvclass--Write%20Logged%20Data.vi.png)
AIM MIL-STD-1553 Engine.lvlib--Implementation.lvlib--Execution Unit.lvclass--Message References to Message Handles.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-aim-milStd1553-custom-device/PR-34/2022-06-07/14%3A51%3A05/AIM%20MIL-STD-1553%20Engine.lvlib--Implementation.lvlib--Execution%20Unit.lvclass--Message%20References%20to%20Message%20Handles.vi.png)
AIM MIL-STD-1553 Engine.lvlib--Implementation.lvlib--Rx Execution Unit.lvclass--Decode Words to Parameters.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-aim-milStd1553-custom-device/PR-34/2022-06-07/14%3A51%3A05/AIM%20MIL-STD-1553%20Engine.lvlib--Implementation.lvlib--Rx%20Execution%20Unit.lvclass--Decode%20Words%20to%20Parameters.vi.png)
AIM MIL-STD-1553 Engine.lvlib--Implementation.lvlib--Rx Execution Unit.lvclass--Initialize Buffer IDs.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-aim-milStd1553-custom-device/PR-34/2022-06-07/14%3A51%3A05/AIM%20MIL-STD-1553%20Engine.lvlib--Implementation.lvlib--Rx%20Execution%20Unit.lvclass--Initialize%20Buffer%20IDs.vi.png)
AIM MIL-STD-1553 Engine.lvlib--Implementation.lvlib--Shared Resources Factory.lvclass--Get 1553 Configuration.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-aim-milStd1553-custom-device/PR-34/2022-06-07/14%3A51%3A05/AIM%20MIL-STD-1553%20Engine.lvlib--Implementation.lvlib--Shared%20Resources%20Factory.lvclass--Get%201553%20Configuration.vi.png)
AIM MIL-STD-1553 Engine.lvlib--Implementation.lvlib--Tx Execution Unit.lvclass--Encode Parameters to Words.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-aim-milStd1553-custom-device/PR-34/2022-06-07/14%3A51%3A05/AIM%20MIL-STD-1553%20Engine.lvlib--Implementation.lvlib--Tx%20Execution%20Unit.lvclass--Encode%20Parameters%20to%20Words.vi.png)
AIM MIL-STD-1553 Engine.lvlib--Implementation.lvlib--Tx Execution Unit.lvclass--Initialize Buffer IDs.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-aim-milStd1553-custom-device/PR-34/2022-06-07/14%3A51%3A05/AIM%20MIL-STD-1553%20Engine.lvlib--Implementation.lvlib--Tx%20Execution%20Unit.lvclass--Initialize%20Buffer%20IDs.vi.png)
AIM MIL-STD-1553 Scripting.lvlib--Add Message (BC to RT, RT to BC).vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-aim-milStd1553-custom-device/PR-34/2022-06-07/14%3A51%3A05/AIM%20MIL-STD-1553%20Scripting.lvlib--Add%20Message%20(BC%20to%20RT%2C%20RT%20to%20BC).vi.png)
Check Value in Range.vim.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-aim-milStd1553-custom-device/PR-34/2022-06-07/14%3A51%3A05/Check%20Value%20in%20Range.vim.png)
Deployment.lvclass--test Deployment Import BC-Only Configuration.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-aim-milStd1553-custom-device/PR-34/2022-06-07/14%3A51%3A05/Deployment.lvclass--test%20Deployment%20Import%20BC-Only%20Configuration.vi.png)
Deployment.lvclass--test Deployment Import Configuration.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-aim-milStd1553-custom-device/PR-34/2022-06-07/14%3A51%3A05/Deployment.lvclass--test%20Deployment%20Import%20Configuration.vi.png)
Deployment.lvclass--test Deployment Import RT-Only Configuration.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-aim-milStd1553-custom-device/PR-34/2022-06-07/14%3A51%3A05/Deployment.lvclass--test%20Deployment%20Import%20RT-Only%20Configuration.vi.png)
Logging Loopback.lvclass--test Correct Subaddresses In Log.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-aim-milStd1553-custom-device/PR-34/2022-06-07/14%3A51%3A05/Logging%20Loopback.lvclass--test%20Correct%20Subaddresses%20In%20Log.vi.png)
Loopback.lvclass--BC to RT with Start Stop and Status.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-aim-milStd1553-custom-device/PR-34/2022-06-07/14%3A51%3A05/Loopback.lvclass--BC%20to%20RT%20with%20Start%20Stop%20and%20Status.vi.png)
Loopback.lvclass--Mode Code 16 with Start Stop and Status.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-aim-milStd1553-custom-device/PR-34/2022-06-07/14%3A51%3A05/Loopback.lvclass--Mode%20Code%2016%20with%20Start%20Stop%20and%20Status.vi.png)
Loopback.lvclass--Mode Code 17 with Start Stop and Status.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-aim-milStd1553-custom-device/PR-34/2022-06-07/14%3A51%3A05/Loopback.lvclass--Mode%20Code%2017%20with%20Start%20Stop%20and%20Status.vi.png)
Loopback.lvclass--RT to BC with Start Stop and Status.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-aim-milStd1553-custom-device/PR-34/2022-06-07/14%3A51%3A05/Loopback.lvclass--RT%20to%20BC%20with%20Start%20Stop%20and%20Status.vi.png)
Loopback.lvclass--RT to RT with Start Stop and Status.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-aim-milStd1553-custom-device/PR-34/2022-06-07/14%3A51%3A05/Loopback.lvclass--RT%20to%20RT%20with%20Start%20Stop%20and%20Status.vi.png)
Loopback.lvclass--Timestamps with Start and Stop Command.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-aim-milStd1553-custom-device/PR-34/2022-06-07/14%3A51%3A05/Loopback.lvclass--Timestamps%20with%20Start%20and%20Stop%20Command.vi.png)
MIL-STD 1553 Import.lvlib--Get Element References by Tag Name.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-aim-milStd1553-custom-device/PR-34/2022-06-07/14%3A51%3A05/MIL-STD%201553%20Import.lvlib--Get%20Element%20References%20by%20Tag%20Name.vi.png)
MIL-STD 1553 Import.lvlib--Parse Parameters File.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-aim-milStd1553-custom-device/PR-34/2022-06-07/14%3A51%3A05/MIL-STD%201553%20Import.lvlib--Parse%20Parameters%20File.vi.png)
MIL-STD 1553 Import.lvlib--Read Acyclic Frames.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-aim-milStd1553-custom-device/PR-34/2022-06-07/14%3A51%3A05/MIL-STD%201553%20Import.lvlib--Read%20Acyclic%20Frames.vi.png)
MIL-STD 1553 Import.lvlib--Read Address.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-aim-milStd1553-custom-device/PR-34/2022-06-07/14%3A51%3A05/MIL-STD%201553%20Import.lvlib--Read%20Address.vi.png)
MIL-STD 1553 Import.lvlib--Read Major Frames.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-aim-milStd1553-custom-device/PR-34/2022-06-07/14%3A51%3A05/MIL-STD%201553%20Import.lvlib--Read%20Major%20Frames.vi.png)
MIL-STD 1553 Import.lvlib--Read Message Type and Terminals.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-aim-milStd1553-custom-device/PR-34/2022-06-07/14%3A51%3A05/MIL-STD%201553%20Import.lvlib--Read%20Message%20Type%20and%20Terminals.vi.png)
MIL-STD 1553 Import.lvlib--Read Messages.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-aim-milStd1553-custom-device/PR-34/2022-06-07/14%3A51%3A05/MIL-STD%201553%20Import.lvlib--Read%20Messages.vi.png)
MIL-STD 1553 Import.lvlib--Read Minor Frames.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-aim-milStd1553-custom-device/PR-34/2022-06-07/14%3A51%3A05/MIL-STD%201553%20Import.lvlib--Read%20Minor%20Frames.vi.png)
MIL-STD 1553 Import.lvlib--Read Number of Words and Parameters.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-aim-milStd1553-custom-device/PR-34/2022-06-07/14%3A51%3A05/MIL-STD%201553%20Import.lvlib--Read%20Number%20of%20Words%20and%20Parameters.vi.png)
MIL-STD 1553 Import.lvlib--Read Parameter Definition.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-aim-milStd1553-custom-device/PR-34/2022-06-07/14%3A51%3A05/MIL-STD%201553%20Import.lvlib--Read%20Parameter%20Definition.vi.png)
MIL-STD 1553 Import.lvlib--Read Tag Value.vim.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-aim-milStd1553-custom-device/PR-34/2022-06-07/14%3A51%3A05/MIL-STD%201553%20Import.lvlib--Read%20Tag%20Value.vim.png)
MIL-STD 1553 Import.lvlib--Read Terminals.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-aim-milStd1553-custom-device/PR-34/2022-06-07/14%3A51%3A05/MIL-STD%201553%20Import.lvlib--Read%20Terminals.vi.png)
MIL-STD 1553 Import.lvlib--Verify Message Type.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-aim-milStd1553-custom-device/PR-34/2022-06-07/14%3A51%3A05/MIL-STD%201553%20Import.lvlib--Verify%20Message%20Type.vi.png)
MIL-STD 1553 Import.lvlib--Verify Terminals for Message Type.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-aim-milStd1553-custom-device/PR-34/2022-06-07/14%3A51%3A05/MIL-STD%201553%20Import.lvlib--Verify%20Terminals%20for%20Message%20Type.vi.png)
SharedUtilities.lvclass--test Value in Range (DBL).vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-aim-milStd1553-custom-device/PR-34/2022-06-07/14%3A51%3A05/SharedUtilities.lvclass--test%20Value%20in%20Range%20(DBL).vi.png)
SharedUtilities.lvclass--test Value in Range (I32).vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-aim-milStd1553-custom-device/PR-34/2022-06-07/14%3A51%3A05/SharedUtilities.lvclass--test%20Value%20in%20Range%20(I32).vi.png)
SharedUtilities.lvclass--test Value in Range (U16).vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-aim-milStd1553-custom-device/PR-34/2022-06-07/14%3A51%3A05/SharedUtilities.lvclass--test%20Value%20in%20Range%20(U16).vi.png)
SharedUtilities.lvclass--test Value to String to Value (Boolean).vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-aim-milStd1553-custom-device/PR-34/2022-06-07/14%3A51%3A05/SharedUtilities.lvclass--test%20Value%20to%20String%20to%20Value%20(Boolean).vi.png)
SharedUtilities.lvclass--test Value to String to Value (Numeric).vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-aim-milStd1553-custom-device/PR-34/2022-06-07/14%3A51%3A05/SharedUtilities.lvclass--test%20Value%20to%20String%20to%20Value%20(Numeric).vi.png)
SharedUtilities.lvclass--test Value to String to Value (String).vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-aim-milStd1553-custom-device/PR-34/2022-06-07/14%3A51%3A05/SharedUtilities.lvclass--test%20Value%20to%20String%20to%20Value%20(String).vi.png)