search

ni / niveristand-aim-milStd1553-custom-device

Custom device for AIM MIL-STD-1553 hardware
MIT License
1 stars 2 forks source link

Remove old maps that are no longer used #38

Closed papowerNI closed 2 years ago

papowerNI commented 2 years ago

What does this Pull Request accomplish?

The old mappings were replaced with maps in Shared Resources that initialize arrays Received Messages and Transmitted Messages, instead of the maps that were used in Ballard 1553. So these are no longer used for anything.

Why should this Pull Request be merged?

These VIs are cluttering up some of the engine code, I'm cleaning it up while working on finishing up cyclic read/write stuff.

What testing has been done?

Created a new custom device, deployed it, and tried reading and writing various values. Also ran the unit tests.

niveristand-diff-bot commented 2 years ago

Bleep bloop!

LabVIEW Diff Robot here with some diffs served up hot for your pull request.

Notice something funny? Help fix me on my GitHub repo.

AIM MIL-STD-1553 Engine.lvlib--Implementation.lvlib--Rx Execution Unit.lvclass--Initialize.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-aim-milStd1553-custom-device/PR-38/2022-06-20/13%3A50%3A41/AIM%20MIL-STD-1553%20Engine.lvlib--Implementation.lvlib--Rx%20Execution%20Unit.lvclass--Initialize.vi.png)
AIM MIL-STD-1553 Engine.lvlib--Implementation.lvlib--Rx Execution Unit.lvclass--Rx Construct.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-aim-milStd1553-custom-device/PR-38/2022-06-20/13%3A50%3A41/AIM%20MIL-STD-1553%20Engine.lvlib--Implementation.lvlib--Rx%20Execution%20Unit.lvclass--Rx%20Construct.vi.png)
AIM MIL-STD-1553 Engine.lvlib--Implementation.lvlib--Tx Execution Unit.lvclass--Initialize.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-aim-milStd1553-custom-device/PR-38/2022-06-20/13%3A50%3A41/AIM%20MIL-STD-1553%20Engine.lvlib--Implementation.lvlib--Tx%20Execution%20Unit.lvclass--Initialize.vi.png)
Create Execution Unit.lvclass--setUp.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-aim-milStd1553-custom-device/PR-38/2022-06-20/13%3A50%3A41/Create%20Execution%20Unit.lvclass--setUp.vi.png)
Create Execution Unit.lvclass--tearDown.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-aim-milStd1553-custom-device/PR-38/2022-06-20/13%3A50%3A41/Create%20Execution%20Unit.lvclass--tearDown.vi.png)
Create Execution Unit.lvclass--test BC + RTs.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-aim-milStd1553-custom-device/PR-38/2022-06-20/13%3A50%3A41/Create%20Execution%20Unit.lvclass--test%20BC%20%2B%20RTs.vi.png)
Create Execution Unit.lvclass--test BC Only.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-aim-milStd1553-custom-device/PR-38/2022-06-20/13%3A50%3A41/Create%20Execution%20Unit.lvclass--test%20BC%20Only.vi.png)