search

ni / niveristand-aim-milStd1553-custom-device

Custom device for AIM MIL-STD-1553 hardware
MIT License
1 stars 2 forks source link

Remove old channel handles #39

Closed papowerNI closed 2 years ago

papowerNI commented 2 years ago

What does this Pull Request accomplish?

Channel Handles were previously passed around but now that the old maps are removed, the necessary data that was in the maps is put into Received Messages and Transmitted Messages arrays, which do not need these handles, so they can be removed.

Why should this Pull Request be merged?

More cleanup of old behavior that was replaced during prototyping of the custom device.

What testing has been done?

Created a new custom device, configured it, deployed it, and ran all of the unit tests.

niveristand-diff-bot commented 2 years ago

Bleep bloop!

LabVIEW Diff Robot here with some diffs served up hot for your pull request.

Notice something funny? Help fix me on my GitHub repo.

AIM MIL-STD-1553 Engine.lvlib--Implementation.lvlib--Address Based Execution Unit.lvclass--1553 Address Handles to Write Info.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-aim-milStd1553-custom-device/PR-39/2022-06-21/09%3A49%3A31/AIM%20MIL-STD-1553%20Engine.lvlib--Implementation.lvlib--Address%20Based%20Execution%20Unit.lvclass--1553%20Address%20Handles%20to%20Write%20Info.vi.png)
AIM MIL-STD-1553 Engine.lvlib--Implementation.lvlib--Execution Unit Factory.lvclass--Create Execution Unit.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-aim-milStd1553-custom-device/PR-39/2022-06-21/09%3A49%3A31/AIM%20MIL-STD-1553%20Engine.lvlib--Implementation.lvlib--Execution%20Unit%20Factory.lvclass--Create%20Execution%20Unit.vi.png)
AIM MIL-STD-1553 Engine.lvlib--Implementation.lvlib--Execution Unit.lvclass--Construct.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-aim-milStd1553-custom-device/PR-39/2022-06-21/09%3A49%3A31/AIM%20MIL-STD-1553%20Engine.lvlib--Implementation.lvlib--Execution%20Unit.lvclass--Construct.vi.png)
AIM MIL-STD-1553 Engine.lvlib--Implementation.lvlib--Execution Unit.lvclass--Get Channels and Messages.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-aim-milStd1553-custom-device/PR-39/2022-06-21/09%3A49%3A31/AIM%20MIL-STD-1553%20Engine.lvlib--Implementation.lvlib--Execution%20Unit.lvclass--Get%20Channels%20and%20Messages.vi.png)
AIM MIL-STD-1553 Engine.lvlib--Implementation.lvlib--Execution Unit.lvclass--Read BIU Configuration.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-aim-milStd1553-custom-device/PR-39/2022-06-21/09%3A49%3A31/AIM%20MIL-STD-1553%20Engine.lvlib--Implementation.lvlib--Execution%20Unit.lvclass--Read%20BIU%20Configuration.vi.png)
AIM MIL-STD-1553 Engine.lvlib--Implementation.lvlib--Logging Execution Unit.lvclass--Logging Construct.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-aim-milStd1553-custom-device/PR-39/2022-06-21/09%3A49%3A31/AIM%20MIL-STD-1553%20Engine.lvlib--Implementation.lvlib--Logging%20Execution%20Unit.lvclass--Logging%20Construct.vi.png)
AIM MIL-STD-1553 Engine.lvlib--Implementation.lvlib--Rx Execution Unit.lvclass--Rx Construct.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-aim-milStd1553-custom-device/PR-39/2022-06-21/09%3A49%3A31/AIM%20MIL-STD-1553%20Engine.lvlib--Implementation.lvlib--Rx%20Execution%20Unit.lvclass--Rx%20Construct.vi.png)
AIM MIL-STD-1553 Engine.lvlib--Implementation.lvlib--Tx Execution Unit.lvclass--Tx Construct.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-aim-milStd1553-custom-device/PR-39/2022-06-21/09%3A49%3A31/AIM%20MIL-STD-1553%20Engine.lvlib--Implementation.lvlib--Tx%20Execution%20Unit.lvclass--Tx%20Construct.vi.png)