search

ni / niveristand-aim-milStd1553-custom-device

Custom device for AIM MIL-STD-1553 hardware
MIT License
1 stars 2 forks source link

[SWITCH TO MAIN BEFORE SUBMIT] Change BIU configuration from array to element and consolidate name #41

Closed papowerNI closed 2 years ago

papowerNI commented 2 years ago

Note: This is not pointing towards main yet. I'm pointing it towards a dependent PR so that the files changed in the previous PR do not show up. I will remove this note before submitting to main.

What does this Pull Request accomplish?

a value from Ballard called 1553 channels is an array because Ballard supported multiple ports, and is also somewhat confusing since it is referring to a cluster that represents the hardware channels in a Parameters File, not a Veristand channel. Since hardware channels are an artifact of Ballard, this is renamed BIU Configuration, since this represents 1 BIU of configuration data.

Why should this Pull Request be merged?

BIU configuration was already added in some places, but this is to cover the rest of the uses, and eliminate the unused "array" scattered around.

What testing has been done?

Created a new custom device, configured it, deployed it, and ran all of the unit tests.

papowerNI commented 2 years ago

This was an attempt at parallelizing PRs, but it doesn't look like github has a good way to redirect the PR later like AzDO does, so I am abandoning the attempt.