Add timestamps

[papowerNI]

• [X] This contribution adheres to CONTRIBUTING.md.

What does this Pull Request accomplish?

Adds timestamps to the Rx channels in the engine, and has the timestamps return time elapsed since the start of the hardware I/O. Also cleans up a couple of VIs in Execution Unit.lvclass for clarity.

Why should this Pull Request be merged?

Timestamps are part of read/write behavior.

What testing has been done?

Added a unit test that checks that timestamp channel handles are added, and that timestamp settings are correctly setup in received/transmitted messages. Tests run, sysdef deployed and manual test of timestamps running:

Testing Read/Write behavior specifically can be done when Read/Write tests are added (after mode codes and acyclic frames exist).

[niveristand-diff-bot]

Bleep bloop!

LabVIEW Diff Robot here with some diffs served up hot for your pull request.

Notice something funny? Help fix me on my GitHub repo.

AIM MIL-STD-1553 Engine.lvlib--Implementation.lvlib--Execution Unit Factory.lvclass--Create Execution Unit.vi.png


AIM MIL-STD-1553 Engine.lvlib--Implementation.lvlib--Execution Unit.lvclass--Compute VS Channel Handle Indices.vi.png


AIM MIL-STD-1553 Engine.lvlib--Implementation.lvlib--Execution Unit.lvclass--Get VS Channel Handles and Messages.vi.png


AIM MIL-STD-1553 Engine.lvlib--Implementation.lvlib--Rx Execution Unit.lvclass--Read from Hardware.vi.png


AIM MIL-STD-1553 Engine.lvlib--Implementation.lvlib--Tx Execution Unit.lvclass--Write to Hardware.vi.png


AIM MIL-STD-1553 Hardware API.lvlib--Read Buffer.vi.png


Create Execution Unit.lvclass--setUp.vi.png


Create Execution Unit.lvclass--test Get VS Channel Handles and Messages.vi.png


Deployment.lvclass--test Deployment Import BC-Only Configuration.vi.png


Deployment.lvclass--test Deployment Import Configuration.vi.png


Deployment.lvclass--test Deployment Import RT-Only Configuration.vi.png


Engine.lvclass--test Compute VS Channel Handle Indices.vi.png


Loopback.lvclass--test Loopback.vi.png


[papowerNI]

Why are the deployment tests now being skipped?

They've actually been failing since I fixed the parameters.xml for them way back in PR 27, because they test deployment of acyclic frames and mode codes. Before fixing the xml, they were basically just deploying empty configurations due to typos in the parameters.xml that cause all of the content to be skipped (messages were not enclosed in so they were all missed). I can remove the checks for acyclic frames and add them back later if that's preferred, but I opted to enable them again when the missing features are included. I could also just leave them failing

[niveristand-diff-bot]

Bleep bloop!

LabVIEW Diff Robot here with some diffs served up hot for your pull request.

Notice something funny? Help fix me on my GitHub repo.

AIM MIL-STD-1553 Engine.lvlib--Implementation.lvlib--Execution Unit Factory.lvclass--Create Execution Unit.vi.png


AIM MIL-STD-1553 Engine.lvlib--Implementation.lvlib--Execution Unit.lvclass--Compute VS Channel Handle Indices.vi.png


AIM MIL-STD-1553 Engine.lvlib--Implementation.lvlib--Execution Unit.lvclass--Get VS Channel Handles and Messages.vi.png


AIM MIL-STD-1553 Engine.lvlib--Implementation.lvlib--Rx Execution Unit.lvclass--Read from Hardware.vi.png


AIM MIL-STD-1553 Engine.lvlib--Implementation.lvlib--Tx Execution Unit.lvclass--Write to Hardware.vi.png


AIM MIL-STD-1553 Hardware API.lvlib--Read Buffer.vi.png


Create Execution Unit.lvclass--test Get VS Channel Handles and Messages.vi.png


Deployment.lvclass--test Deployment Import BC-Only Configuration.vi.png


Deployment.lvclass--test Deployment Import Configuration.vi.png


Deployment.lvclass--test Deployment Import RT-Only Configuration.vi.png


Engine.lvclass--test Compute VS Channel Handle Indices.vi.png


Loopback.lvclass--test Loopback.vi.png