ni / niveristand-aim-milStd1553-custom-device

Custom device for AIM MIL-STD-1553 hardware
MIT License
1 stars 2 forks source link

Add support for Mode Codes #45

Closed papowerNI closed 2 years ago

papowerNI commented 2 years ago

What does this Pull Request accomplish?

Why should this Pull Request be merged?

Mode codes needed for initial release.

What testing has been done?

Manually validated that mode codes work, and added unit tests and added mode codes to Loopback system test. Tests passed: image

niveristand-diff-bot commented 2 years ago

Bleep bloop!

LabVIEW Diff Robot here with some diffs served up hot for your pull request.

Notice something funny? Help fix me on my GitHub repo.

AIM MIL-STD-1553 Engine.lvlib--Implementation.lvlib--Rx Execution Unit.lvclass--Initialize Buffer IDs.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-aim-milStd1553-custom-device/PR-45/2022-06-30/18%3A02%3A22/AIM%20MIL-STD-1553%20Engine.lvlib--Implementation.lvlib--Rx%20Execution%20Unit.lvclass--Initialize%20Buffer%20IDs.vi.png)
AIM MIL-STD-1553 Engine.lvlib--Implementation.lvlib--Shared Resources Factory.lvclass--Convert Message Definition to Message Configuration.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-aim-milStd1553-custom-device/PR-45/2022-06-30/18%3A02%3A22/AIM%20MIL-STD-1553%20Engine.lvlib--Implementation.lvlib--Shared%20Resources%20Factory.lvclass--Convert%20Message%20Definition%20to%20Message%20Configuration.vi.png)
AIM MIL-STD-1553 Engine.lvlib--Implementation.lvlib--Shared Resources Factory.lvclass--Get 1553 Configuration.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-aim-milStd1553-custom-device/PR-45/2022-06-30/18%3A02%3A22/AIM%20MIL-STD-1553%20Engine.lvlib--Implementation.lvlib--Shared%20Resources%20Factory.lvclass--Get%201553%20Configuration.vi.png)
AIM MIL-STD-1553 Engine.lvlib--Implementation.lvlib--Shared Resources.lvclass--Initialize Bus Controller.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-aim-milStd1553-custom-device/PR-45/2022-06-30/18%3A02%3A22/AIM%20MIL-STD-1553%20Engine.lvlib--Implementation.lvlib--Shared%20Resources.lvclass--Initialize%20Bus%20Controller.vi.png)
AIM MIL-STD-1553 Engine.lvlib--Implementation.lvlib--Shared Resources.lvclass--Initialize Hardware.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-aim-milStd1553-custom-device/PR-45/2022-06-30/18%3A02%3A22/AIM%20MIL-STD-1553%20Engine.lvlib--Implementation.lvlib--Shared%20Resources.lvclass--Initialize%20Hardware.vi.png)
AIM MIL-STD-1553 Engine.lvlib--Implementation.lvlib--Shared Resources.lvclass--Initialize Remote Terminals.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-aim-milStd1553-custom-device/PR-45/2022-06-30/18%3A02%3A22/AIM%20MIL-STD-1553%20Engine.lvlib--Implementation.lvlib--Shared%20Resources.lvclass--Initialize%20Remote%20Terminals.vi.png)
AIM MIL-STD-1553 Engine.lvlib--Implementation.lvlib--Tx Execution Unit.lvclass--Initialize Buffer IDs.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-aim-milStd1553-custom-device/PR-45/2022-06-30/18%3A02%3A22/AIM%20MIL-STD-1553%20Engine.lvlib--Implementation.lvlib--Tx%20Execution%20Unit.lvclass--Initialize%20Buffer%20IDs.vi.png)
AIM MIL-STD-1553 Engine.lvlib--Implementation.lvlib--Tx Execution Unit.lvclass--Write to Hardware.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-aim-milStd1553-custom-device/PR-45/2022-06-30/18%3A02%3A22/AIM%20MIL-STD-1553%20Engine.lvlib--Implementation.lvlib--Tx%20Execution%20Unit.lvclass--Write%20to%20Hardware.vi.png)
AIM MIL-STD-1553 Hardware API.lvlib--Initialize Mode Code.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-aim-milStd1553-custom-device/PR-45/2022-06-30/18%3A02%3A22/AIM%20MIL-STD-1553%20Hardware%20API.lvlib--Initialize%20Mode%20Code.vi.png)
AIM MIL-STD-1553 Hardware API.lvlib--Update Buffer Words.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-aim-milStd1553-custom-device/PR-45/2022-06-30/18%3A02%3A22/AIM%20MIL-STD-1553%20Hardware%20API.lvlib--Update%20Buffer%20Words.vi.png)
AIM MIL-STD-1553 Scripting.lvlib--Find Subaddress.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-aim-milStd1553-custom-device/PR-45/2022-06-30/18%3A02%3A22/AIM%20MIL-STD-1553%20Scripting.lvlib--Find%20Subaddress.vi.png)
AIM MIL-STD-1553 Scripting.lvlib--Get Mode Code.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-aim-milStd1553-custom-device/PR-45/2022-06-30/18%3A02%3A22/AIM%20MIL-STD-1553%20Scripting.lvlib--Get%20Mode%20Code.vi.png)
Create Execution Unit.lvclass--Run EU and SR Factories.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-aim-milStd1553-custom-device/PR-45/2022-06-30/18%3A02%3A22/Create%20Execution%20Unit.lvclass--Run%20EU%20and%20SR%20Factories.vi.png)
Create Execution Unit.lvclass--test Convert Message Definition to Message Configuration.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-aim-milStd1553-custom-device/PR-45/2022-06-30/18%3A02%3A22/Create%20Execution%20Unit.lvclass--test%20Convert%20Message%20Definition%20to%20Message%20Configuration.vi.png)
Create Execution Unit.lvclass--test Get VS Channel Handles and Messages.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-aim-milStd1553-custom-device/PR-45/2022-06-30/18%3A02%3A22/Create%20Execution%20Unit.lvclass--test%20Get%20VS%20Channel%20Handles%20and%20Messages.vi.png)
Create Execution Unit.lvclass--test Initialize Buffer IDs.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-aim-milStd1553-custom-device/PR-45/2022-06-30/18%3A02%3A22/Create%20Execution%20Unit.lvclass--test%20Initialize%20Buffer%20IDs.vi.png)
Scripting.lvclass--test Add-Find-Remove Subaddress.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-aim-milStd1553-custom-device/PR-45/2022-06-30/18%3A02%3A22/Scripting.lvclass--test%20Add-Find-Remove%20Subaddress.vi.png)
Karl-G1 commented 2 years ago

We should also note in the PR notes the change from using the Write Data Word / Write Data Words VIs to using Update Buffer Words.vi.

niveristand-diff-bot commented 2 years ago

Bleep bloop!

LabVIEW Diff Robot here with some diffs served up hot for your pull request.

Notice something funny? Help fix me on my GitHub repo.

AIM MIL-STD-1553 Engine.lvlib--Implementation.lvlib--Rx Execution Unit.lvclass--Initialize Buffer IDs.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-aim-milStd1553-custom-device/PR-45/2022-07-01/11%3A32%3A53/AIM%20MIL-STD-1553%20Engine.lvlib--Implementation.lvlib--Rx%20Execution%20Unit.lvclass--Initialize%20Buffer%20IDs.vi.png)
AIM MIL-STD-1553 Engine.lvlib--Implementation.lvlib--Shared Resources Factory.lvclass--Convert Message Definition to Message Configuration.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-aim-milStd1553-custom-device/PR-45/2022-07-01/11%3A32%3A53/AIM%20MIL-STD-1553%20Engine.lvlib--Implementation.lvlib--Shared%20Resources%20Factory.lvclass--Convert%20Message%20Definition%20to%20Message%20Configuration.vi.png)
AIM MIL-STD-1553 Engine.lvlib--Implementation.lvlib--Shared Resources Factory.lvclass--Get 1553 Configuration.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-aim-milStd1553-custom-device/PR-45/2022-07-01/11%3A32%3A53/AIM%20MIL-STD-1553%20Engine.lvlib--Implementation.lvlib--Shared%20Resources%20Factory.lvclass--Get%201553%20Configuration.vi.png)
AIM MIL-STD-1553 Engine.lvlib--Implementation.lvlib--Shared Resources.lvclass--Initialize Bus Controller.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-aim-milStd1553-custom-device/PR-45/2022-07-01/11%3A32%3A53/AIM%20MIL-STD-1553%20Engine.lvlib--Implementation.lvlib--Shared%20Resources.lvclass--Initialize%20Bus%20Controller.vi.png)
AIM MIL-STD-1553 Engine.lvlib--Implementation.lvlib--Shared Resources.lvclass--Initialize Hardware.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-aim-milStd1553-custom-device/PR-45/2022-07-01/11%3A32%3A53/AIM%20MIL-STD-1553%20Engine.lvlib--Implementation.lvlib--Shared%20Resources.lvclass--Initialize%20Hardware.vi.png)
AIM MIL-STD-1553 Engine.lvlib--Implementation.lvlib--Shared Resources.lvclass--Initialize Remote Terminals.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-aim-milStd1553-custom-device/PR-45/2022-07-01/11%3A32%3A53/AIM%20MIL-STD-1553%20Engine.lvlib--Implementation.lvlib--Shared%20Resources.lvclass--Initialize%20Remote%20Terminals.vi.png)
AIM MIL-STD-1553 Engine.lvlib--Implementation.lvlib--Tx Execution Unit.lvclass--Initialize Buffer IDs.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-aim-milStd1553-custom-device/PR-45/2022-07-01/11%3A32%3A53/AIM%20MIL-STD-1553%20Engine.lvlib--Implementation.lvlib--Tx%20Execution%20Unit.lvclass--Initialize%20Buffer%20IDs.vi.png)
AIM MIL-STD-1553 Engine.lvlib--Implementation.lvlib--Tx Execution Unit.lvclass--Write to Hardware.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-aim-milStd1553-custom-device/PR-45/2022-07-01/11%3A32%3A53/AIM%20MIL-STD-1553%20Engine.lvlib--Implementation.lvlib--Tx%20Execution%20Unit.lvclass--Write%20to%20Hardware.vi.png)
AIM MIL-STD-1553 Hardware API.lvlib--Initialize Mode Code.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-aim-milStd1553-custom-device/PR-45/2022-07-01/11%3A32%3A53/AIM%20MIL-STD-1553%20Hardware%20API.lvlib--Initialize%20Mode%20Code.vi.png)
AIM MIL-STD-1553 Hardware API.lvlib--Update Buffer Words.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-aim-milStd1553-custom-device/PR-45/2022-07-01/11%3A32%3A53/AIM%20MIL-STD-1553%20Hardware%20API.lvlib--Update%20Buffer%20Words.vi.png)
AIM MIL-STD-1553 Scripting.lvlib--Find Subaddress.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-aim-milStd1553-custom-device/PR-45/2022-07-01/11%3A32%3A53/AIM%20MIL-STD-1553%20Scripting.lvlib--Find%20Subaddress.vi.png)
AIM MIL-STD-1553 Scripting.lvlib--Get Mode Code.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-aim-milStd1553-custom-device/PR-45/2022-07-01/11%3A32%3A53/AIM%20MIL-STD-1553%20Scripting.lvlib--Get%20Mode%20Code.vi.png)
Create Execution Unit.lvclass--Run EU and SR Factories.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-aim-milStd1553-custom-device/PR-45/2022-07-01/11%3A32%3A53/Create%20Execution%20Unit.lvclass--Run%20EU%20and%20SR%20Factories.vi.png)
Create Execution Unit.lvclass--test Convert Message Definition to Message Configuration.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-aim-milStd1553-custom-device/PR-45/2022-07-01/11%3A32%3A53/Create%20Execution%20Unit.lvclass--test%20Convert%20Message%20Definition%20to%20Message%20Configuration.vi.png)
Create Execution Unit.lvclass--test Get VS Channel Handles and Messages.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-aim-milStd1553-custom-device/PR-45/2022-07-01/11%3A32%3A53/Create%20Execution%20Unit.lvclass--test%20Get%20VS%20Channel%20Handles%20and%20Messages.vi.png)
Create Execution Unit.lvclass--test Initialize Buffer IDs.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-aim-milStd1553-custom-device/PR-45/2022-07-01/11%3A32%3A53/Create%20Execution%20Unit.lvclass--test%20Initialize%20Buffer%20IDs.vi.png)
Scripting.lvclass--test Add-Find-Remove Subaddress.vi.png ![capture](https://raw.githubusercontent.com/niveristand-diff-bot/diff-images/master/NI/niveristand-aim-milStd1553-custom-device/PR-45/2022-07-01/11%3A32%3A53/Scripting.lvclass--test%20Add-Find-Remove%20Subaddress.vi.png)